feat(router-plugin): provide more actions and navigation timing option #1932

arturovt · 2022-11-05T22:56:19Z

I finally got my hands to the router plugin. Its implementation was initially tied from the ngrx router package. I had to sync the implementation again.

I can't push my changes separately as they're all part of the same fix. This fixes old issues and adds new actions + router option (like navigation timing).

bundlemon · 2022-11-06T19:28:04Z

BundleMon

Unchanged files (6)

Status	Path	Size	Limits
✅	fesm5/ngxs-store.js	137.67KB	145KB / +0.5%
✅	fesm2015/ngxs-store.js	118.39KB	125KB / +0.5%
✅	fesm5/ngxs-store-operators.js	10.07KB	15KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	9.94KB	15KB / +0.5%
✅	fesm5/ngxs-store-internals.js	6.58KB	20KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	5.65KB	20KB / +0.5%

No change in files bundle size

Unchanged groups (6)

Status	Path	Size	Limits
✅	@ngxs/store(esm5)[gzip] _{./esm5/*/.js}	179.31KB	+1%
✅	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	172.59KB	+1%
✅	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	40.57KB	+1%
✅	@ngxs/store(fesm5)[gzip] _./fesm5/*.js	29.86KB	+1%
✅	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	27.33KB	+1%
✅	@ngxs/store(umd.min)[gzip] _{./bundles/*.umd.min.js}	13.65KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-11-06T19:28:06Z

BundleMon (NGXS Plugins)

Files updated (4)

Status	Path	Size	Limits
❌	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	7.28KB (+802B +12.05%)	+1%
❌	Plugins(fesm5)[gzip] _{router-plugin/fesm5/ngxs-router-plugin.js}	3.91KB (+775B +24.03%)	+1%
❌	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	3.56KB (+686B +23.2%)	+1%
❌	Plugins(umd.min)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. min.js}	2.72KB (+243B +9.56%)	+1%

Unchanged files (24)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.98KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.96KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.87KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	6.53KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	6.44KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	5.77KB	+1%
✅	Plugins(fesm5)[gzip] _{storage-plugin/fesm5/ngxs-storage-plugin.js}	4.67KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	4.35KB	+1%
✅	Plugins(fesm5)[gzip] _{hmr-plugin/fesm5/ngxs-hmr-plugin.js}	3.62KB	+1%
✅	Plugins(fesm5)[gzip] _{websocket-plugin/fesm5/ngxs-websocket-plugin. js}	3.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	3.25KB	+1%
✅	Plugins(fesm5)[gzip] _{devtools-plugin/fesm5/ngxs-devtools-plugin.js}	3.21KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	3.15KB	+1%
✅	Plugins(umd.min)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js}	3.1KB	+1%
✅	Plugins(fesm5)[gzip] _{form-plugin/fesm5/ngxs-form-plugin.js}	3.07KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	3.03KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.74KB	+1%
✅	Plugins(umd.min)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.min.js}	2.54KB	+1%
✅	Plugins(fesm5)[gzip] _{logger-plugin/fesm5/ngxs-logger-plugin.js}	2.48KB	+1%
✅	Plugins(umd.min)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.min. js}	2.43KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.37KB	+1%
✅	Plugins(umd.min)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.min.js}	2.18KB	+1%
✅	Plugins(umd.min)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. min.js}	1.95KB	+1%
✅	Plugins(umd.min)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.min.js}	1.86KB	+1%

Total files change +2.45KB +2.24%

Groups updated (6)

Status	Path	Size	Limits
❌	All Plugins(esm5)[gzip] _{./-plugin/esm5/**/.js}	128.77KB (+3.98KB +3.19%)	+1%
❌	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	123.36KB (+3.9KB +3.26%)	+1%
❌	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	47.84KB (+802B +1.66%)	+1%
❌	All Plugins(fesm5)[gzip] _{./-plugin/fesm5/.js}	24.49KB (+775B +3.19%)	+1%
❌	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	22.45KB (+686B +3.08%)	+1%
❌	All Plugins(umd.min)[gzip] _{./-plugin/bundles/.umd.min.js}	16.77KB (+243B +1.43%)	+1%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2022-11-06T19:28:09Z

BundleMon (Integration Projects)

Files updated (4)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng11-ivy/dist-integration/main.(h ash).js}	71.26KB (+134B +0.18%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	67.97KB (+132B +0.19%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	65.59KB (+130B +0.19%)	+1%
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.9KB (+124B +0.17%)	+1%

Total files change +520B +0.19%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

codeclimate · 2022-12-07T07:14:17Z

Code Climate has analyzed commit 95679e4 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	3

The test coverage on the diff in this pull request is 97.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.0% change).

View more on Code Climate.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.6/3.8.0) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.6/3.8.0) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.6/3.8.0) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.8.0`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#380-2023-03-29) [Compare Source](ngxs/store@v3.7.6...v3.8.0) - Feature: Build packages in Ivy format [#1945](ngxs/store#1945) - Feature: Add advanced selector utilities [#1824](ngxs/store#1824) - Feature: Expose `ActionContext` and `ActionStatus` [#1766](ngxs/store#1766) - Feature: `ofAction*` methods should have strong types [#1808](ngxs/store#1808) - Feature: Improve contextual type inference for state operators [#1806](ngxs/store#1806) [#1947](ngxs/store#1947) - Feature: Enable warning on unhandled actions [#1870](ngxs/store#1870) [#1951](ngxs/store#1951) - Feature: Router Plugin - Provide more actions and navigation timing option [#1932](ngxs/store#1932) - Feature: Storage Plugin - Allow providing namespace for keys [#1841](ngxs/store#1841) - Feature: Storage Plugin - Enable providing storage engine individually [#1935](ngxs/store#1935) - Feature: Devtools Plugin - Add new options to the `NgxsDevtoolsOptions` interface [#1879](ngxs/store#1879) - Feature: Devtools Plugin - Add trace options to `NgxsDevtoolsOptions` [#1968](ngxs/store#1968) - Feature: Form Plugin - Allow `ngxsFormDebounce` to be string [#1972](ngxs/store#1972) - Performance: Tree-shake patch errors [#1955](ngxs/store#1955) - Fix: Get descriptor explicitly when it's considered as a class property [#1961](ngxs/store#1961) - Fix: Avoid delayed updates from state stream [#1981](ngxs/store#1981) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1837 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

arturovt force-pushed the fix/router-plugin-issues branch from fc7d328 to 02632b8 Compare November 6, 2022 19:07

arturovt added this to the v3.7.6 milestone Nov 6, 2022

arturovt force-pushed the fix/router-plugin-issues branch 2 times, most recently from f41af41 to e891611 Compare November 6, 2022 19:25

arturovt marked this pull request as ready for review November 6, 2022 22:54

arturovt requested review from markwhitfeld, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners November 6, 2022 22:54

arturovt force-pushed the fix/router-plugin-issues branch 2 times, most recently from d3d5116 to 9fc0dcc Compare November 6, 2022 23:13

arturovt changed the title ~~fix(router-plugin): update implementation to keep backwards behaviour~~ feat(router-plugin): provide more actions and navigation timing option Nov 6, 2022

arturovt removed this from the v3.7.6 milestone Nov 8, 2022

arturovt added the type: feature label Nov 13, 2022

arturovt added this to the v3.8.0 milestone Nov 23, 2022

markwhitfeld approved these changes Dec 6, 2022

View reviewed changes

arturovt force-pushed the fix/router-plugin-issues branch 2 times, most recently from e48880a to fd9a834 Compare December 6, 2022 21:34

feat(router-plugin): provide more actions and navigation timing option

95679e4

arturovt force-pushed the fix/router-plugin-issues branch from fd9a834 to 95679e4 Compare December 7, 2022 07:09

arturovt merged commit a585f14 into master Dec 7, 2022

arturovt deleted the fix/router-plugin-issues branch December 7, 2022 07:18

markwhitfeld added the released label Mar 29, 2023

abdulrahman305 mentioned this pull request Jul 3, 2024

[Snyk] Upgrade: , , , , abdulrahman305/auptimizer#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(router-plugin): provide more actions and navigation timing option #1932

feat(router-plugin): provide more actions and navigation timing option #1932

arturovt commented Nov 5, 2022 •

edited

Loading

bundlemon bot commented Nov 6, 2022 •

edited

Loading

bundlemon bot commented Nov 6, 2022 •

edited

Loading

bundlemon bot commented Nov 6, 2022 •

edited

Loading

codeclimate bot commented Dec 7, 2022

feat(router-plugin): provide more actions and navigation timing option #1932

feat(router-plugin): provide more actions and navigation timing option #1932

Conversation

arturovt commented Nov 5, 2022 • edited Loading

bundlemon bot commented Nov 6, 2022 • edited Loading

BundleMon

bundlemon bot commented Nov 6, 2022 • edited Loading

BundleMon (NGXS Plugins)

bundlemon bot commented Nov 6, 2022 • edited Loading

BundleMon (Integration Projects)

codeclimate bot commented Dec 7, 2022

arturovt commented Nov 5, 2022 •

edited

Loading

bundlemon bot commented Nov 6, 2022 •

edited

Loading

bundlemon bot commented Nov 6, 2022 •

edited

Loading

bundlemon bot commented Nov 6, 2022 •

edited

Loading