Update add entry behaviour #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badges for Travis CI, AppVeyor, Coveralls, and Codacy.
I also added one system test for this just to be safe. However since behaviour of the parser has already been checked to result in the same command objects, there should not be an issue with divergent behaviour using alias/nonalias commands.
…serguide Update userguide
…nd-aliases Add command aliases, unit tests for command and parser.
* Add CSS tag color styles to DarkTheme * Modify PersonCard to use tag color styles * Add helper method to get style classes from tag in PersonCardHandle * Add test for equal tag color styles in GuiTestAssert::assertCardEquals * Add test for correct tag color styles in GuiTestAssert::assertCardDisplaysPerson * Add test helper method to get tag color style class from tag name in GuiTestAssert * Add test helper method to assert tags and tag color styles are equal
Update Developer Guide to match our product. Needs future updates as development progresses.
* Added more features and marked v2.0 features
* Added error style for ResultDisplay * Added and updated tests for ResultDisplay Tests to check style for successful and error feedback * Updated MainWindow for ResultDisplay error Now ResultDisplay shows the correct error when executeCommand catches an invalid command * Updated accessibility of method in ResultDisplay * Inlined private method To improve readability. * Added error style checking for system tests
* Update About Us page with CS2103-AY1819S2-W10-1 team member names, personal Github links, roles and responsibilities * Add thomastanck About Us image docs/images/thomastanck.jpg * Add rlrh About Us image docs/images/rlrh.jpg * Add qjqqyy About Us image docs/images/qjqqyy.png * Add epicfailname About Us image docs/images/epicfailname.png * Remove unused images
In order to determine how many entries were returned by a `find` command, or how many entries there are in the addressbook in total, the user has to scroll down. We modify StatusBarFooter to show the total number of persons displayed in the view. System tests for this is too numerous and will be added in the future.
* Add stub for Network component Returns "Hello World" for any given String URL * Make Network an abstract class Removes the need of having concrete class NetworkManager
…command result and exception
* Refactor Person -> Entry * Refactor Name -> Title Note to self: Changing fields in Entry must change equivalent labels in PersonCard/PersonCardHandle * Refactor Email -> Link * Refactor Phone -> Comment * Fix checkstyle bugs * Refactor NameContains... -> TitleContains.. NameContainsKeywordsPredicate -> TitleContainsKeyWordsPredicate * Change default data file path addressbook.json -> entrybook.json * Fix checkstyle bugs * Refactor AddressBook -> EntryBook * Fix checkstyle bugs * Refactor .json files for Storage tests Person -> Entry AddressBook -> EntryBook * Refactor Json..AddressBook.. -> Json..EntryBook.. * Remove .json config and data files It will be created automatically if not found, with the correct names and fields (corresponding to entry book). Important to note that for this to take effect, you'll need to delete preference.json and data/addressbook.json first. * Refactor Person Excetions, Person -> Entry * Refactor JsonAdaptedPerson -> JsonAdaptedEntry * Refactor UI name Person -> Entry * Refactor AddressBookParser -> EntryBookParser * Refactor rename tests Person -> Entry AddressBook -> EntryBook * Toggle visibility of "Address" field "Address" still present internally, just not visible * Refactor rename app window title/ status bar info * Remove visibility of "Address" field in Entry Internally, "Address" field is now a optional input field (still works if you use "add" command with "a/" prefix), with a default placeholder if none is given. Tests requiring non-null "Address" field are commented off. * Refactor argument prefixes Title: n/ -> ti/ (Used to be Name) Comment: p/ -> c/ (Used to be Phone) Link: e/ -> l/ (Used to be Email) * Updated parsers for Title, Comment and Link Title: Accepts non-empty, any value Comment: Accepts non-empty, any value (Might want to make optional field in future) Link: protocol//path * Remove debugging code * Fix checkstyle bugs * Refactor UI messages for commands * Revert debugging code changes GuiRobot wait time set back to 250ms * Fix checkstyle bugs * Fix dead link and incorrect URL example * Refactor to-be deprecated parser for Address Change title to Readme
This reverts commit 309b603.
we are using the term Title over Headline.
Implements initial RSS Support in the form of `feed` command, which imports an entire RSS feed in.
Add issue template for user stories. Feel free to suggest changes! This was made using the issue template maker in the Github repo settings, I don't actually know the actual file format they use.
…1/thomastanck-patch-1 Update issue templates
Fix template headers in User Story Issue Template
…1/thomastanck-patch-1 Update issue templates
Readme: Remove irrelevant links, add links to additional libraries used
Along with tests to match behaviour
To-be-deprecated Address field also has default as empty String
cchj1995
pushed a commit
to cchj1995/addressbook-level4
that referenced
this pull request
Mar 25, 2019
…entation Update documentation
yinya998
pushed a commit
to yinya998/CS2103
that referenced
this pull request
Mar 25, 2019
…revert-83-master Revert "update userGuide, developerGuide and test cases week10 mid1.3"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43
Resolves part of #19
Summary of changes
CommenttoDescriptionTitleandDescriptionnot compulsory fields when adding anEntryaddoreditto an entryLink,Description) have two separate validity regex checks for its StringvalueEntry'sisSameEntry()functionTitleand (CommentorLink) for comparisonLinkfor comparison