-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schedule command #258
Closed
hjuntan
wants to merge
281
commits into
nus-cs2103-AY2324S2:master
from
AY2324S2-CS2103T-T15-2:add-schedule-command
Closed
Add schedule command #258
hjuntan
wants to merge
281
commits into
nus-cs2103-AY2324S2:master
from
AY2324S2-CS2103T-T15-2:add-schedule-command
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation 1.1
Group images, CI status are updated to the correct format. Project scope is updated to fit the tp project.
Documentation
Documentation 1.1
Edit Find feature of UserGuide.md
FindCommand now requires up to 5 predicates to be matched. Added the skeleton of these and edit FindCommand to include these predicates Let's add correct logic to the test function of these skeletons.
Add required Predicates for FindCommand
Tags are now represented as groups, tutorial groups A person can be assigned for multilple groups.
Tags are the following value: Student, TA, Professor, None. Tags are case-sensitive. (Top be improved on) Able to easily distinguish between the people in the address book. Addresses are removed as we deemed it as unnecessary information for our target user.
Each person has an NUSID field which is uniquely identifies the person.
Add simple description to each Predicate. Describe what each tests for.
Add JavaDoc to Predicates
Edit person fields
Fix import order of Tag Predicate
Edit person class
Add schedule command to DG
Allow group command to take multiple groups
Add test cases for ScheduleParser
Add more date formats for schedule
Add PinSequenceDiagram and Edit UG
Add more features to DG
… branch-ui-change
Add nusId prefix to Edit Command
Add more data formats for schedule command
Resolve merge conflict in DeleteCommandParser
Add test cases
Change edit command to include nusId prefix
Add testcases for ScheduleCommandParser and compulsory remark field
kaiyi27
added a commit
to kaiyi27/tp
that referenced
this pull request
Apr 15, 2024
Modify figure number in UG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.