0.1.x #2332
Closed
0.1.x #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that lead to an error because we tried to concatenate a table (`err`) to a string. Now we concatenate `err.message` (a string) to the string.
We did not check `val ~= nil` in the resolve functions, so config like
`{ nil, max = 30 }` will throw a nil error. Also, if the config is `{
padding = _ }`, the logic relies on the function handling the padding is
iterated before the one handling min/max in the map, which is not always
guaranteed.
Fix the bug by adding nil check in the function handling min/max. Close
after refactor to some new asynchronous items for finders, the tests stopped actually doing anything. now they do things again.
path needs to be expanded for filereadable and isdirectory
Co-authored-by: Bryce Montano <[email protected]>
* Starting to make some progress on extmarks for prefixes * Finished up extmarks for multi-icons * Cleaned up update_prefix calls, added display highlights * remove highlight_one_row * Remove TODOs * stylua fixes * fixes for luacheck * Fixed whitespace to appease the stylua gods * fixed a couple nits from pr * Got tests passing with new highlighting functionality * Apply suggestions from code review Co-authored-by: Fabian David Schmidt <[email protected]> Co-authored-by: Fabian David Schmidt <[email protected]>
…#2099)" (nvim-telescope#2138) This reverts commit 8d13f4c.
Due to regression from switching to lua autocmd api pickers were resized only once.
…cope#2150) neovim/neovim#19931 removed `_get_hl_from_capture(id)` since captures are now implicitly mapped to highlight groups with the same name.
…nvim-telescope#2275) * fix(builtin.live_grep): add spacer ":" even when coordinates disabled * fix docgen Co-authored-by: Simon Hauser <[email protected]>
…#2288) Co-authored-by: Cyan Joeng <[email protected]>
telescope.nvim is a common dependency across Neovim plugins. Using luarocks may alleviate the need for users to specify their plugins' dependencies in their plugin manager. (e.g., vim-plug or packer). See also: https://teto.github.io/posts/2021-09-17-neovim-plugin-luarocks.html
|
can you please open a PR against master, dev is done against master and fixes are backported to 0.1.x (by cherry-picking commits) Also this shouldn't be done every time |
|
ok,thanks |
Conni2461
added a commit
to Conni2461/telescope.nvim
that referenced
this pull request
Feb 19, 2023
Conni2461
added a commit
that referenced
this pull request
Feb 19, 2023
|
i resolved that myself because this pr includes like 77 unrelated already merged commits and it was to much hustle for me to figure out what went wrong with git here. None the less, thanks :) bug is fixed on master and will be backported to 0.1.x later today |
|
thanks,ha ha ,i just change little lines，and don't konw why so much diff 😅 |
Conni2461
added a commit
that referenced
this pull request
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescope current_buffer_fuzzy_findchange cursor position but it doesn't seem to add current cursor position to jumplist, so i addvim.cmd [[ normal! m' ]]to lua/telescope/builtin/__files.lua cols 412 https://neovim.discourse.group/t/how-to-add-the-current-cursor-position-to-the-jump-list/1585no add
vim.cmd [[ normal! m' ]]https://user-images.githubusercontent.com/43649186/213096883-f72d0ef9-0715-4560-9e9b-97710a9062fe.mp4
after add
vim.cmd [[ normal! m' ]]https://user-images.githubusercontent.com/43649186/213097016-1025d74b-c27d-41ed-8bd0-08b1258555cd.mp4