Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawning with namespace #444

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Spawning with namespace #444

merged 2 commits into from
Aug 24, 2023

Conversation

pijaro
Copy link
Contributor

@pijaro pijaro commented Aug 2, 2023

Support for namespace parameter in the robot spawner.

@pijaro pijaro requested review from a team as code owners August 2, 2023 12:36
zakmat
zakmat reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@zakmat zakmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also waiting for the namespace support in spawnables. I hope it will be merged soon! I have added some comments for consideration

Gems/ROS2/Code/Source/Spawner/ROS2SpawnerComponent.cpp Outdated Show resolved Hide resolved
Gems/ROS2/Code/Source/Spawner/ROS2SpawnerComponent.cpp Show resolved Hide resolved
@pijaro pijaro mentioned this pull request Aug 3, 2023
Merged
1 task
@pijaro pijaro requested review from adamdbrw and zakmat August 9, 2023 09:18
@lewandowskikacper lewandowskikacper mentioned this pull request Aug 21, 2023
Closed
adamdbrw
adamdbrw approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some ideas about NamespaceConfiguration refactor, so that it can be set dynamically as a whole configuration.

pijaro added 2 commits August 23, 2023 18:55
@pijaro @michalpelka
Spawning with namespace
957460c 
Signed-off-by: Piotr Jaroszek <[email protected]>
@pijaro @michalpelka
Review applied
d29f6d7 
Signed-off-by: Piotr Jaroszek <[email protected]>
@michalpelka michalpelka force-pushed the spawner_with_namespace_support branch from 98c9f20 to d29f6d7 Compare August 23, 2023 16:55
@adamdbrw adamdbrw merged commit c5b7c01 into development Aug 24, 2023
@adamdbrw adamdbrw mentioned this pull request Sep 29, 2023
Closed
@michalpelka michalpelka deleted the spawner_with_namespace_support branch November 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakmat zakmat zakmat approved these changes

@michalpelka michalpelka michalpelka approved these changes

@adamdbrw adamdbrw adamdbrw approved these changes

@pawelbudziszewski pawelbudziszewski pawelbudziszewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pijaro @zakmat @michalpelka @adamdbrw @pawelbudziszewski