Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet navigation ROS 2 package and assets #450

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

pijaro
Copy link
Contributor

@pijaro pijaro commented Aug 3, 2023

Ros2FleetRobotTemplate update.

A fleet navigation ROS 2 package was added to the template. It is based on nav2_bringup package.

Navigation with AMCL for multiple robots.

Assumes that the namespace spawning is implemented (#444).

Zip archive will be added after the review:

  • Zip archive updated.

@pijaro pijaro marked this pull request as ready for review August 3, 2023 13:34
Copy link
Contributor

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need someone to test the instructions

Copy link
Contributor

@lewandowskikacper lewandowskikacper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Params are not copied correctly during project creation from this template (humble and iron subdirectories are not copied). This causes a crash when launching o3de_fleet_nav_launch.py as in the instruction.

[INFO] [launch]: Default logging verbosity is set to INFO
ReplaceString substitution error:  [Errno 2] No such file or directory: '/home/kacper/projects/FleetNavigation/Examples/ros2_ws/install/o3de_fleet_nav/share/o3de_fleet_nav/params/humble/nav2_multirobot_params.yaml'
[ERROR] [launch]: Caught exception in launch (see debug for traceback): local variable 'input_file' referenced before assignment

Copying the files from ~/o3de-extras/Templates/Ros2FleetRobotTemplate/Template/Examples/ros2_ws/src/o3de_fleet_nav/params/ to ~/projects/FleetNavigation/Examples/ros2_ws/src/o3de_fleet_nav/params/ fixes that.

Possibly, those files should be included in template.json?

Templates/Ros2FleetRobotTemplate/template.json Outdated Show resolved Hide resolved
Templates/Ros2FleetRobotTemplate/README.md Outdated Show resolved Hide resolved
Templates/Ros2FleetRobotTemplate/README.md Outdated Show resolved Hide resolved
@lewandowskikacper
Copy link
Contributor

I created a project from this template and run it (on humble).
Apart from the problems listed above, the project and example run as expected.

Some comment about map creation could be useful (how to update it, when the warehouse is modified).

@adamdbrw
Copy link
Contributor

@lewandowskikacper @pijaro are all issues resolved?

@pijaro pijaro closed this Aug 21, 2023
@pijaro pijaro reopened this Aug 21, 2023
@pijaro
Copy link
Contributor Author

pijaro commented Aug 22, 2023

Review applied.

As for the map creation, we can go with a new issue and work on slam/map building example 👍

Copy link
Contributor

@michalpelka michalpelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed. Please merge #444 ASAP.

@michalpelka
Copy link
Contributor

rebased

@michalpelka michalpelka force-pushed the feature/fleet_navigation_template_ros2ws branch from d51d6b9 to 54770b8 Compare August 23, 2023 16:52
@adamdbrw adamdbrw merged commit 02ff6f8 into development Aug 24, 2023
@michalpelka michalpelka deleted the feature/fleet_navigation_template_ros2ws branch November 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants