-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet navigation ROS 2 package and assets #450
Fleet navigation ROS 2 package and assets #450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we need someone to test the instructions
.../Ros2FleetRobotTemplate/Template/Examples/ros2_ws/src/o3de_fleet_nav/params/nav2_params.yaml
Outdated
Show resolved
Hide resolved
d4d5ed4
to
745adc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Params are not copied correctly during project creation from this template (humble
and iron
subdirectories are not copied). This causes a crash when launching o3de_fleet_nav_launch.py
as in the instruction.
[INFO] [launch]: Default logging verbosity is set to INFO
ReplaceString substitution error: [Errno 2] No such file or directory: '/home/kacper/projects/FleetNavigation/Examples/ros2_ws/install/o3de_fleet_nav/share/o3de_fleet_nav/params/humble/nav2_multirobot_params.yaml'
[ERROR] [launch]: Caught exception in launch (see debug for traceback): local variable 'input_file' referenced before assignment
Copying the files from ~/o3de-extras/Templates/Ros2FleetRobotTemplate/Template/Examples/ros2_ws/src/o3de_fleet_nav/params/ to ~/projects/FleetNavigation/Examples/ros2_ws/src/o3de_fleet_nav/params/ fixes that.
Possibly, those files should be included in template.json
?
I created a project from this template and run it (on humble). Some comment about map creation could be useful (how to update it, when the warehouse is modified). |
@lewandowskikacper @pijaro are all issues resolved? |
Templates/Ros2FleetRobotTemplate/Template/Examples/ros2_ws/src/o3de_fleet_nav/NOTICE
Outdated
Show resolved
Hide resolved
...os2FleetRobotTemplate/Template/Examples/ros2_ws/src/o3de_fleet_nav/launch/o3de_nav_launch.py
Outdated
Show resolved
Hide resolved
Review applied. As for the map creation, we can go with a new issue and work on slam/map building example 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and reviewed. Please merge #444 ASAP.
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
rebased |
d51d6b9
to
54770b8
Compare
Ros2FleetRobotTemplate
update.A fleet navigation ROS 2 package was added to the template. It is based on nav2_bringup package.
Navigation with AMCL for multiple robots.
Assumes that the namespace spawning is implemented (#444).
Zip archive will be added after the review: