-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): Adding local provisioner pv build for ppc64le #1632
Conversation
@akhilerm Can you please help with validating the security/snyk and GolangCI issues? I didn't change stuff and it looks like something is broken there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base image to be used for ppc64le
needs to be checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@akhilerm Any idea why Better Code Hub is panicking? I only changed the commit message, and unfortunately I dont have access to check the report. |
@Pensu can you rebase the changes from master and try pushing again. BetterCodeHub is complaining about code that you haven't modified. |
Signed-off-by: Peeyush Gupta <[email protected]>
@akhilerm So Better Code Hub is happy, but security/synk has some issues. While checking on details it says the project needs to be resynced. |
@Pensu I think the snyk issue can be ignored for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good. thanks @Pensu for taking this up.
/lgtm
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md). The following community members have been helping with enhancing and testing of several areas of the OpenEBS project that broadly fall in the purview of the control plane. Based on their past contributions and their interest/commitment to contributing to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project. The list of community members in alphabetical order are: - Mehran Kholdi for the contributions to the Local PV and control plane in general. ``` - openebs#2975 - 40+ commits in https://github.com/openebs/rawfile-localpv ``` - Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane. ``` - openebs-archive/e2e-tests#405 - openebs#3038 - openebs#3023 - openebs#3037 - openebs#1295 - openebs/linux-utils#5 - openebs-archive/node-disk-manager#446 - openebs-archive/node-disk-manager#449 - openebs-archive/node-disk-manager#428 ``` - Peeyush Gupta for the contributions to the Power builds and control plane in general. ``` - openebs/charts#127 - openebs-archive/node-disk-manager#448 - openebs-archive/maya#1632 - openebs-archive/jiva#279 - openebs-archive/maya#667 - openebs-archive/istgt#131 - openebs-archive/maya#561 - openebs-archive/maya#750 ``` Signed-off-by: kmova <[email protected]>
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md). The following community members have been helping with enhancing and testing of several areas of the OpenEBS project that broadly fall in the purview of the control plane. Based on their past contributions and their interest/commitment to contributing to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project. The list of community members in alphabetical order are: - Mehran Kholdi for the contributions to the Local PV and control plane in general. ``` - #2975 - 40+ commits in https://github.com/openebs/rawfile-localpv ``` - Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane. ``` - openebs-archive/e2e-tests#405 - #3038 - #3023 - #3037 - #1295 - openebs/linux-utils#5 - openebs-archive/node-disk-manager#446 - openebs-archive/node-disk-manager#449 - openebs-archive/node-disk-manager#428 ``` - Peeyush Gupta for the contributions to the Power builds and control plane in general. ``` - openebs/charts#127 - openebs-archive/node-disk-manager#448 - openebs-archive/maya#1632 - openebs-archive/jiva#279 - openebs-archive/maya#667 - openebs-archive/istgt#131 - openebs-archive/maya#561 - openebs-archive/maya#750 ``` Signed-off-by: kmova <[email protected]>
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md). The following community members have been helping with enhancing and testing of several areas of the OpenEBS project that broadly fall in the purview of the control plane. Based on their past contributions and their interest/commitment to contributing to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project. The list of community members in alphabetical order are: - Mehran Kholdi for the contributions to the Local PV and control plane in general. ``` - openebs#2975 - 40+ commits in https://github.com/openebs/rawfile-localpv ``` - Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane. ``` - openebs-archive/e2e-tests#405 - openebs#3038 - openebs#3023 - openebs#3037 - openebs#1295 - openebs/linux-utils#5 - openebs-archive/node-disk-manager#446 - openebs-archive/node-disk-manager#449 - openebs-archive/node-disk-manager#428 ``` - Peeyush Gupta for the contributions to the Power builds and control plane in general. ``` - openebs/charts#127 - openebs-archive/node-disk-manager#448 - openebs-archive/maya#1632 - openebs-archive/jiva#279 - openebs-archive/maya#667 - openebs-archive/istgt#131 - openebs-archive/maya#561 - openebs-archive/maya#750 ``` Signed-off-by: kmova <[email protected]> Signed-off-by: Kung Fu Panda <[email protected]>
What this PR does / why we need it:
This PR adds local provisioner builds for ppc64le.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentation
tagbreaking-changes
tagrequires-upgrade
tag