Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Adding local provisioner pv build for ppc64le #1632

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

Pensu
Copy link
Contributor

@Pensu Pensu commented Mar 17, 2020

What this PR does / why we need it:

This PR adds local provisioner builds for ppc64le.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

@Pensu Pensu force-pushed the localpv_ppc64le branch from 760fad6 to 5d526b3 Compare March 17, 2020 04:55
@Pensu
Copy link
Contributor Author

Pensu commented Mar 18, 2020

@akhilerm Can you please help with validating the security/snyk and GolangCI issues? I didn't change stuff and it looks like something is broken there.

@akhilerm
Copy link
Contributor

@Pensu I think its some error from the Github application side. Those tools have failed for all recent PRs. I think we can work on the code and review, and the tools should get fixed in the meantime
cc: @kmova

Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base image to be used for ppc64le needs to be checked.

GNUmakefile Show resolved Hide resolved
@akhilerm
Copy link
Contributor

changes are good.
@Pensu can you also change the commit message format as specified here

@Pensu Pensu changed the title Adding local provisioner pv build for ppc64le feat(build): Adding local provisioner pv build for ppc64le Mar 26, 2020
@Pensu Pensu force-pushed the localpv_ppc64le branch from 5d526b3 to 816b400 Compare March 31, 2020 14:10
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Pensu
Copy link
Contributor Author

Pensu commented Apr 2, 2020

@akhilerm Any idea why Better Code Hub is panicking? I only changed the commit message, and unfortunately I dont have access to check the report.

@akhilerm
Copy link
Contributor

akhilerm commented Apr 2, 2020

@Pensu can you rebase the changes from master and try pushing again. BetterCodeHub is complaining about code that you haven't modified.

@Pensu Pensu force-pushed the localpv_ppc64le branch from 816b400 to 07aa153 Compare April 6, 2020 10:41
@Pensu
Copy link
Contributor Author

Pensu commented Apr 6, 2020

@akhilerm So Better Code Hub is happy, but security/synk has some issues. While checking on details it says the project needs to be resynced.

@akhilerm
Copy link
Contributor

akhilerm commented Apr 6, 2020

@Pensu I think the snyk issue can be ignored for now.

Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good. thanks @Pensu for taking this up.
/lgtm

@kmova kmova merged commit 2d51e0d into openebs-archive:master Apr 7, 2020
kmova added a commit to kmova/openebs that referenced this pull request Jul 15, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - openebs#2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs-archive/e2e-tests#405
  - openebs#3038
  - openebs#3023
  - openebs#3037
  - openebs#1295
  - openebs/linux-utils#5
  - openebs-archive/node-disk-manager#446
  - openebs-archive/node-disk-manager#449
  - openebs-archive/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs-archive/node-disk-manager#448
  - openebs-archive/maya#1632
  - openebs-archive/jiva#279
  - openebs-archive/maya#667
  - openebs-archive/istgt#131
  - openebs-archive/maya#561
  - openebs-archive/maya#750
  ```

Signed-off-by: kmova <[email protected]>
kmova added a commit to openebs/openebs that referenced this pull request Jul 15, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - #2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs-archive/e2e-tests#405
  - #3038
  - #3023
  - #3037
  - #1295
  - openebs/linux-utils#5
  - openebs-archive/node-disk-manager#446
  - openebs-archive/node-disk-manager#449
  - openebs-archive/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs-archive/node-disk-manager#448
  - openebs-archive/maya#1632
  - openebs-archive/jiva#279
  - openebs-archive/maya#667
  - openebs-archive/istgt#131
  - openebs-archive/maya#561
  - openebs-archive/maya#750
  ```

Signed-off-by: kmova <[email protected]>
Akshay-Nagle pushed a commit to Akshay-Nagle/openebs that referenced this pull request Oct 7, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - openebs#2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs-archive/e2e-tests#405
  - openebs#3038
  - openebs#3023
  - openebs#3037
  - openebs#1295
  - openebs/linux-utils#5
  - openebs-archive/node-disk-manager#446
  - openebs-archive/node-disk-manager#449
  - openebs-archive/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs-archive/node-disk-manager#448
  - openebs-archive/maya#1632
  - openebs-archive/jiva#279
  - openebs-archive/maya#667
  - openebs-archive/istgt#131
  - openebs-archive/maya#561
  - openebs-archive/maya#750
  ```

Signed-off-by: kmova <[email protected]>
Signed-off-by: Kung Fu Panda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants