Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): add support for multiarch build #5

Merged
merged 8 commits into from
Aug 5, 2020
Merged

chore(build): add support for multiarch build #5

merged 8 commits into from
Aug 5, 2020

Conversation

akhilerm
Copy link
Contributor

  • added support for multiarch image with the following supported platforms (amd64, arm64, armv7, ppc64le)
  • removed arm64 and ppc64le from travis builds
  • remove pushing image from travis. Image will be pushed from github actions
  • refactored build script to add new targets to make use of docker buildx
  • added the following workflows into github actions
    • release
    • ci
    • build

Signed-off-by: Akhil Mohan [email protected]

akhilerm added 3 commits July 13, 2020 18:21
@akhilerm
chore(build): add make targets to build image using buildx
042691e 
Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm
chore(build): remove arm64 and ppc64 from travis
49e9d38 
Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm
chore(build, workflow): add github workflows
ede7f64 
add workflow for the following tasks
- release
- pull request
- general build/push

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm akhilerm requested a review from kmova July 13, 2020 13:08
@akhilerm
Copy link
Contributor Author

cc: @xunholy

@kmova kmova requested review from Pensu and xunholy July 15, 2020 07:45
kmova added a commit to kmova/openebs that referenced this pull request Jul 15, 2020
@kmova
feat(governance): add new contributors to OpenEBS
66a9b04 
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - openebs#2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs-archive/e2e-tests#405
  - openebs#3038
  - openebs#3023
  - openebs#3037
  - openebs#1295
  - openebs/linux-utils#5
  - openebs-archive/node-disk-manager#446
  - openebs-archive/node-disk-manager#449
  - openebs-archive/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs-archive/node-disk-manager#448
  - openebs-archive/maya#1632
  - openebs-archive/jiva#279
  - openebs-archive/maya#667
  - openebs-archive/istgt#131
  - openebs-archive/maya#561
  - openebs-archive/maya#750
  ```

Signed-off-by: kmova <[email protected]>
kmova added a commit to openebs/openebs that referenced this pull request Jul 15, 2020
@kmova
feat(governance): add new contributors to OpenEBS
5f42095 
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - #2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs-archive/e2e-tests#405
  - #3038
  - #3023
  - #3037
  - #1295
  - openebs/linux-utils#5
  - openebs-archive/node-disk-manager#446
  - openebs-archive/node-disk-manager#449
  - openebs-archive/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs-archive/node-disk-manager#448
  - openebs-archive/maya#1632
  - openebs-archive/jiva#279
  - openebs-archive/maya#667
  - openebs-archive/istgt#131
  - openebs-archive/maya#561
  - openebs-archive/maya#750
  ```

Signed-off-by: kmova <[email protected]>
xunholy
xunholy reviewed Jul 16, 2020
View reviewed changes
Copy link

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any consideration to merge the .mk files? Perhaps once the travis CI is deprecated?

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
@akhilerm
added newline at EOF
85cf65f 
Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm akhilerm requested a review from Pensu July 21, 2020 10:46
Pensu
Pensu approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@Pensu Pensu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilerm
Copy link
Contributor Author

akhilerm commented Aug 3, 2020

@xunholy @Pensu , I have made one more change in the push script to remove v prefix in image name. It is related to #137. PTAL

xunholy
xunholy approved these changes Aug 3, 2020
View reviewed changes
Copy link

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kmova
kmova reviewed Aug 4, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
@kmova kmova merged commit 1daa105 into openebs:master Aug 5, 2020
Akshay-Nagle pushed a commit to Akshay-Nagle/openebs that referenced this pull request Oct 7, 2020
@kmova @Akshay-Nagle
feat(governance): add new contributors to OpenEBS
4771a3a 
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - openebs#2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs-archive/e2e-tests#405
  - openebs#3038
  - openebs#3023
  - openebs#3037
  - openebs#1295
  - openebs/linux-utils#5
  - openebs-archive/node-disk-manager#446
  - openebs-archive/node-disk-manager#449
  - openebs-archive/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs-archive/node-disk-manager#448
  - openebs-archive/maya#1632
  - openebs-archive/jiva#279
  - openebs-archive/maya#667
  - openebs-archive/istgt#131
  - openebs-archive/maya#561
  - openebs-archive/maya#750
  ```

Signed-off-by: kmova <[email protected]>
Signed-off-by: Kung Fu Panda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pensu Pensu Pensu approved these changes

@kmova kmova kmova approved these changes

@xunholy xunholy xunholy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akhilerm @Pensu @kmova @xunholy