chore(build): refactor buildx script and add ci builds #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xunholy PTAL. This PR is for enabling mulitarch builds on pull requests. |
refactor buildx scripts to disable push and instead load the image to local docker Signed-off-by: Akhil Mohan <[email protected]>
- refactor buildx scripts to specify image result to load, push or keep in cache - added workflow to build image on pull requests Signed-off-by: Akhil Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 61 61
Lines 2968 2968
=======================================
Hits 1291 1291
Misses 1575 1575
Partials 102 102 Continue to review full report at Codecov.
|
Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
architecture-fix
branch
from
5de101e to
4258e35
Compare
Signed-off-by: Akhil Mohan <[email protected]>
xunholy
reviewed
Jul 6, 2020
Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
|
@kmova Made the requested changes. |
kmova
approved these changes
Jul 7, 2020
kmova
added a commit
to kmova/openebs
that referenced
this pull request
Jul 15, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md). The following community members have been helping with enhancing and testing of several areas of the OpenEBS project that broadly fall in the purview of the control plane. Based on their past contributions and their interest/commitment to contributing to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project. The list of community members in alphabetical order are: - Mehran Kholdi for the contributions to the Local PV and control plane in general. ``` - openebs#2975 - 40+ commits in https://github.com/openebs/rawfile-localpv ``` - Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane. ``` - openebs-archive/e2e-tests#405 - openebs#3038 - openebs#3023 - openebs#3037 - openebs#1295 - openebs/linux-utils#5 - openebs-archive/node-disk-manager#446 - openebs-archive/node-disk-manager#449 - openebs-archive/node-disk-manager#428 ``` - Peeyush Gupta for the contributions to the Power builds and control plane in general. ``` - openebs/charts#127 - openebs-archive/node-disk-manager#448 - openebs-archive/maya#1632 - openebs-archive/jiva#279 - openebs-archive/maya#667 - openebs-archive/istgt#131 - openebs-archive/maya#561 - openebs-archive/maya#750 ``` Signed-off-by: kmova <[email protected]>
kmova
added a commit
to openebs/openebs
that referenced
this pull request
Jul 15, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md). The following community members have been helping with enhancing and testing of several areas of the OpenEBS project that broadly fall in the purview of the control plane. Based on their past contributions and their interest/commitment to contributing to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project. The list of community members in alphabetical order are: - Mehran Kholdi for the contributions to the Local PV and control plane in general. ``` - #2975 - 40+ commits in https://github.com/openebs/rawfile-localpv ``` - Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane. ``` - openebs-archive/e2e-tests#405 - #3038 - #3023 - #3037 - #1295 - openebs/linux-utils#5 - openebs-archive/node-disk-manager#446 - openebs-archive/node-disk-manager#449 - openebs-archive/node-disk-manager#428 ``` - Peeyush Gupta for the contributions to the Power builds and control plane in general. ``` - openebs/charts#127 - openebs-archive/node-disk-manager#448 - openebs-archive/maya#1632 - openebs-archive/jiva#279 - openebs-archive/maya#667 - openebs-archive/istgt#131 - openebs-archive/maya#561 - openebs-archive/maya#750 ``` Signed-off-by: kmova <[email protected]>
Akshay-Nagle
pushed a commit
to Akshay-Nagle/openebs
that referenced
this pull request
Oct 7, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md). The following community members have been helping with enhancing and testing of several areas of the OpenEBS project that broadly fall in the purview of the control plane. Based on their past contributions and their interest/commitment to contributing to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project. The list of community members in alphabetical order are: - Mehran Kholdi for the contributions to the Local PV and control plane in general. ``` - openebs#2975 - 40+ commits in https://github.com/openebs/rawfile-localpv ``` - Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane. ``` - openebs-archive/e2e-tests#405 - openebs#3038 - openebs#3023 - openebs#3037 - openebs#1295 - openebs/linux-utils#5 - openebs-archive/node-disk-manager#446 - openebs-archive/node-disk-manager#449 - openebs-archive/node-disk-manager#428 ``` - Peeyush Gupta for the contributions to the Power builds and control plane in general. ``` - openebs/charts#127 - openebs-archive/node-disk-manager#448 - openebs-archive/maya#1632 - openebs-archive/jiva#279 - openebs-archive/maya#667 - openebs-archive/istgt#131 - openebs-archive/maya#561 - openebs-archive/maya#750 ``` Signed-off-by: kmova <[email protected]> Signed-off-by: Kung Fu Panda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
Currently, multiarch images are built only after merging the changes to master. This PR adds a workflow to build the multiarch image for pull requests.
What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Yes, built and loaded single platform image using buildx
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Continuation of #428
Checklist:
<type>(<scope>): <subject>