Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi step registration eventing #1226

Conversation

syedsajjadkazmii
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii commented Apr 15, 2024

Description

This PR implements multi step registration experiment eventing

JIRA

VAN-1907

How Has This Been Tested?

Locally

Events:

Event Props Use
edx.bi.user.multistepregistration.step1.viewed variation is fired when user falls in a variation and lands on first step of registration
edx.bi.user.multistepregistration.step2.viewed variation is fired when user lands on second step of registration
edx.bi.user.multistepregistration.step3.viewed none is fired when user lands on second step of registration
edx.bi.user.registration.step1.submit.click variation is fired when user clicks CTA on first step of registration page
edx.bi.user.registration.step2.submit.click variation is fired when user clicks CTA on second step of registration page
edx.bi.user.registration.step3.submit.click {} is fired when user clicks CTA on third step of registration page
edx.bi.user.registration.form.submit.click variation is fired when user clicks CTA with valid data on first step in the CONTROL variant and on second step in multi step variant
edx.bi.user.registration.sso.btn.click variation is fired when user clicks SSO btn when lands on first step of registration page

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner April 15, 2024 08:19
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1907-multi-step-registration-events branch from dd73fd4 to d057d9b Compare April 16, 2024 10:18
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1902-multi-step-registration branch from 75596a3 to 0f778cb Compare April 16, 2024 11:34
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1907-multi-step-registration-events branch 5 times, most recently from d54c081 to 3881bae Compare April 17, 2024 11:31
Comment on lines 321 to +329

if (multiStepRegistrationExpVariation === CONTROL
&& multiStepRegistrationPageStep === SECOND_STEP) {
trackMultiStepRegistrationStep2SubmitBtnClicked(multiStepRegistrationExpVariation);
}
if (multiStepRegistrationExpVariation === MULTI_STEP_REGISTRATION_EXP_VARIATION
&& multiStepRegistrationPageStep === THIRD_STEP) {
trackMultiStepRegistrationStep3SubmitBtnClicked();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we add these conditions below?

Copy link
Contributor Author

@syedsajjadkazmii syedsajjadkazmii Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may need more understanding of your comment. What does it mean by below?

By below do you mean along with step1 and step2 clicks? If yes, we can do that but we may need to change the code there as well. Those conditions are used for validating the steps of registration page except last step. So those conditions only run for non-last steps.

Adding here was simple and straight forward, therefore I added here.

But if meant something else, we can discuss.

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1902-multi-step-registration branch from 0f778cb to b9f0dd2 Compare April 18, 2024 05:28
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1907-multi-step-registration-events branch from 3881bae to 0fe848c Compare April 18, 2024 05:55
@syedsajjadkazmii syedsajjadkazmii merged commit a270423 into sajjad/VAN-1902-multi-step-registration Apr 18, 2024
5 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-1907-multi-step-registration-events branch April 18, 2024 06:04
syedsajjadkazmii added a commit that referenced this pull request Apr 18, 2024
* feat: implement multi step registration experiment

* feat: add multi step registration eventing
ahtesham-quraish pushed a commit that referenced this pull request May 7, 2024
* feat: implement multi step registration experiment

* feat: add multi step registration eventing
ahtesham-quraish pushed a commit that referenced this pull request May 7, 2024
* feat: implement multi step registration experiment

* feat: add multi step registration eventing
mubbsharanwar pushed a commit that referenced this pull request Jun 5, 2024
* feat: implement multi step registration experiment

* feat: add multi step registration eventing
mubbsharanwar pushed a commit that referenced this pull request Jun 7, 2024
* feat: implement multi step registration experiment

* feat: add multi step registration eventing
mubbsharanwar added a commit that referenced this pull request Jun 7, 2024
* feat: Hide preloaders for third party auth providers if they are disabled

* feat: remove username from the registration from (#1201) (#1241)

Co-authored-by: Attiya Ishaque <[email protected]>

* fix: add new entry for another US label (#1244)

Add new entry for for another US label which is United States

* feat: implement multi step registration experiment

Rebase 2u main with master (#1228)

* chore(deps): update dependency babel-plugin-formatjs to v10.5.14

* fix(deps): update dependency @edx/frontend-platform to v7.1.3

* fix(deps): update font awesome to v6.5.2

* chore(deps): update dependency @openedx/frontend-build to v13.1.4

* fix(deps): update dependency @openedx/paragon to v22.2.1

* fix(deps): update dependency algoliasearch to v4.23.3

* fix(deps): update dependency algoliasearch-helper to v3.17.0

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: add multi step registration eventing (#1226)

* feat: implement multi step registration experiment

* feat: add multi step registration eventing

* fix: fix register button width

* fix: fix register button loader for control

* feat: capture marketing lead in experiment events (#1243)

* revert: multistep registration experiment
revert multistep registration experiment changes

VAN-1930

* feat: implement auto generated username experiment (#1248)

* feat: implement auto generated username registration exp

* feat: add page event for reset password (#1253)

Description: Add page event for reset password page
VAN-1929

---------

Co-authored-by: Stanislav Lunyachek <[email protected]>
Co-authored-by: Syed Sajjad Hussain Shah <[email protected]>
Co-authored-by: Attiya Ishaque <[email protected]>
Co-authored-by: Blue <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Syed Sajjad  Hussain Shah <[email protected]>
mubbsharanwar pushed a commit that referenced this pull request Sep 12, 2024
* feat: implement multi step registration experiment

* feat: add multi step registration eventing
mubbsharanwar added a commit that referenced this pull request Sep 12, 2024
* feat: Hide preloaders for third party auth providers if they are disabled

* feat: remove username from the registration from (#1201) (#1241)

Co-authored-by: Attiya Ishaque <[email protected]>

* fix: add new entry for another US label (#1244)

Add new entry for for another US label which is United States

* feat: implement multi step registration experiment

Rebase 2u main with master (#1228)

* chore(deps): update dependency babel-plugin-formatjs to v10.5.14

* fix(deps): update dependency @edx/frontend-platform to v7.1.3

* fix(deps): update font awesome to v6.5.2

* chore(deps): update dependency @openedx/frontend-build to v13.1.4

* fix(deps): update dependency @openedx/paragon to v22.2.1

* fix(deps): update dependency algoliasearch to v4.23.3

* fix(deps): update dependency algoliasearch-helper to v3.17.0

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: add multi step registration eventing (#1226)

* feat: implement multi step registration experiment

* feat: add multi step registration eventing

* fix: fix register button width

* fix: fix register button loader for control

* feat: capture marketing lead in experiment events (#1243)

* revert: multistep registration experiment
revert multistep registration experiment changes

VAN-1930

* feat: implement auto generated username experiment (#1248)

* feat: implement auto generated username registration exp

* feat: add page event for reset password (#1253)

Description: Add page event for reset password page
VAN-1929

---------

Co-authored-by: Stanislav Lunyachek <[email protected]>
Co-authored-by: Syed Sajjad Hussain Shah <[email protected]>
Co-authored-by: Attiya Ishaque <[email protected]>
Co-authored-by: Blue <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Syed Sajjad  Hussain Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants