-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multi step registration eventing #1226
feat: add multi step registration eventing #1226
Conversation
dd73fd4
to
d057d9b
Compare
75596a3
to
0f778cb
Compare
d54c081
to
3881bae
Compare
|
||
if (multiStepRegistrationExpVariation === CONTROL | ||
&& multiStepRegistrationPageStep === SECOND_STEP) { | ||
trackMultiStepRegistrationStep2SubmitBtnClicked(multiStepRegistrationExpVariation); | ||
} | ||
if (multiStepRegistrationExpVariation === MULTI_STEP_REGISTRATION_EXP_VARIATION | ||
&& multiStepRegistrationPageStep === THIRD_STEP) { | ||
trackMultiStepRegistrationStep3SubmitBtnClicked(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we add these conditions below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may need more understanding of your comment. What does it mean by below?
By below do you mean along with step1 and step2 clicks? If yes, we can do that but we may need to change the code there as well. Those conditions are used for validating the steps of registration page except last step. So those conditions only run for non-last steps.
Adding here was simple and straight forward, therefore I added here.
But if meant something else, we can discuss.
0f778cb
to
b9f0dd2
Compare
3881bae
to
0fe848c
Compare
a270423
into
sajjad/VAN-1902-multi-step-registration
* feat: implement multi step registration experiment * feat: add multi step registration eventing
* feat: implement multi step registration experiment * feat: add multi step registration eventing
* feat: implement multi step registration experiment * feat: add multi step registration eventing
* feat: implement multi step registration experiment * feat: add multi step registration eventing
* feat: implement multi step registration experiment * feat: add multi step registration eventing
* feat: Hide preloaders for third party auth providers if they are disabled * feat: remove username from the registration from (#1201) (#1241) Co-authored-by: Attiya Ishaque <[email protected]> * fix: add new entry for another US label (#1244) Add new entry for for another US label which is United States * feat: implement multi step registration experiment Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add multi step registration eventing (#1226) * feat: implement multi step registration experiment * feat: add multi step registration eventing * fix: fix register button width * fix: fix register button loader for control * feat: capture marketing lead in experiment events (#1243) * revert: multistep registration experiment revert multistep registration experiment changes VAN-1930 * feat: implement auto generated username experiment (#1248) * feat: implement auto generated username registration exp * feat: add page event for reset password (#1253) Description: Add page event for reset password page VAN-1929 --------- Co-authored-by: Stanislav Lunyachek <[email protected]> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]> Co-authored-by: Attiya Ishaque <[email protected]> Co-authored-by: Blue <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]>
* feat: implement multi step registration experiment * feat: add multi step registration eventing
* feat: Hide preloaders for third party auth providers if they are disabled * feat: remove username from the registration from (#1201) (#1241) Co-authored-by: Attiya Ishaque <[email protected]> * fix: add new entry for another US label (#1244) Add new entry for for another US label which is United States * feat: implement multi step registration experiment Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add multi step registration eventing (#1226) * feat: implement multi step registration experiment * feat: add multi step registration eventing * fix: fix register button width * fix: fix register button loader for control * feat: capture marketing lead in experiment events (#1243) * revert: multistep registration experiment revert multistep registration experiment changes VAN-1930 * feat: implement auto generated username experiment (#1248) * feat: implement auto generated username registration exp * feat: add page event for reset password (#1253) Description: Add page event for reset password page VAN-1929 --------- Co-authored-by: Stanislav Lunyachek <[email protected]> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]> Co-authored-by: Attiya Ishaque <[email protected]> Co-authored-by: Blue <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]>
Description
This PR implements multi step registration experiment eventing
JIRA
VAN-1907
How Has This Been Tested?
Locally
Events:
edx.bi.user.multistepregistration.step1.viewed
edx.bi.user.multistepregistration.step2.viewed
edx.bi.user.multistepregistration.step3.viewed
edx.bi.user.registration.step1.submit.click
edx.bi.user.registration.step2.submit.click
edx.bi.user.registration.step3.submit.click
edx.bi.user.registration.form.submit.click
edx.bi.user.registration.sso.btn.click
Merge Checklist
Post-merge Checklist