generated from openedx/frontend-template-application
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2u-main with master #1254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Attiya Ishaque <[email protected]>
Add new entry for for another US label which is United States
attiyaIshaque
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. I tested it locally and I think it's ready to be merged.
2c004ab
to
e3dc801
Compare
Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: implement multi step registration experiment * feat: add multi step registration eventing
revert multistep registration experiment changes VAN-1930
* feat: implement auto generated username registration exp
Description: Add page event for reset password page VAN-1929
e3dc801
to
f711dcd
Compare
mubbsharanwar
added a commit
that referenced
this pull request
Sep 12, 2024
* feat: Hide preloaders for third party auth providers if they are disabled * feat: remove username from the registration from (#1201) (#1241) Co-authored-by: Attiya Ishaque <[email protected]> * fix: add new entry for another US label (#1244) Add new entry for for another US label which is United States * feat: implement multi step registration experiment Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add multi step registration eventing (#1226) * feat: implement multi step registration experiment * feat: add multi step registration eventing * fix: fix register button width * fix: fix register button loader for control * feat: capture marketing lead in experiment events (#1243) * revert: multistep registration experiment revert multistep registration experiment changes VAN-1930 * feat: implement auto generated username experiment (#1248) * feat: implement auto generated username registration exp * feat: add page event for reset password (#1253) Description: Add page event for reset password page VAN-1929 --------- Co-authored-by: Stanislav Lunyachek <[email protected]> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]> Co-authored-by: Attiya Ishaque <[email protected]> Co-authored-by: Blue <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating PR to update 2u-main branch rebasing with master