feat: capture marketing lead in experiment events #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,7 +145,8 @@ const RegistrationPage = (props) => { | |||
| setErrorCode({ type: '', count: 0 }); | |||
| const nextStep = getMultiStepRegistrationNextStep(multiStepRegistrationPageStep); | |||
| if (nextStep === SECOND_STEP) { | |||
| trackMultiStepRegistrationStep2Viewed(multiStepRegistrationExpVariation); | |||
| const isMarketingLead = formFields.email && configurableFormFields?.marketingEmailsOptIn; | |||
There was a problem hiding this comment.
i know formFields.email && is useless here but i still added for logical sense.
zainab-amir
approved these changes
Apr 25, 2024
ahtesham-quraish
pushed a commit
that referenced
this pull request
May 7, 2024
ahtesham-quraish
pushed a commit
that referenced
this pull request
May 7, 2024
mubbsharanwar
pushed a commit
that referenced
this pull request
Jun 5, 2024
mubbsharanwar
pushed a commit
that referenced
this pull request
Jun 7, 2024
mubbsharanwar
added a commit
that referenced
this pull request
Jun 7, 2024
* feat: Hide preloaders for third party auth providers if they are disabled * feat: remove username from the registration from (#1201) (#1241) Co-authored-by: Attiya Ishaque <[email protected]> * fix: add new entry for another US label (#1244) Add new entry for for another US label which is United States * feat: implement multi step registration experiment Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add multi step registration eventing (#1226) * feat: implement multi step registration experiment * feat: add multi step registration eventing * fix: fix register button width * fix: fix register button loader for control * feat: capture marketing lead in experiment events (#1243) * revert: multistep registration experiment revert multistep registration experiment changes VAN-1930 * feat: implement auto generated username experiment (#1248) * feat: implement auto generated username registration exp * feat: add page event for reset password (#1253) Description: Add page event for reset password page VAN-1929 --------- Co-authored-by: Stanislav Lunyachek <[email protected]> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]> Co-authored-by: Attiya Ishaque <[email protected]> Co-authored-by: Blue <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]>
mubbsharanwar
pushed a commit
that referenced
this pull request
Sep 12, 2024
mubbsharanwar
added a commit
that referenced
this pull request
Sep 12, 2024
* feat: Hide preloaders for third party auth providers if they are disabled * feat: remove username from the registration from (#1201) (#1241) Co-authored-by: Attiya Ishaque <[email protected]> * fix: add new entry for another US label (#1244) Add new entry for for another US label which is United States * feat: implement multi step registration experiment Rebase 2u main with master (#1228) * chore(deps): update dependency babel-plugin-formatjs to v10.5.14 * fix(deps): update dependency @edx/frontend-platform to v7.1.3 * fix(deps): update font awesome to v6.5.2 * chore(deps): update dependency @openedx/frontend-build to v13.1.4 * fix(deps): update dependency @openedx/paragon to v22.2.1 * fix(deps): update dependency algoliasearch to v4.23.3 * fix(deps): update dependency algoliasearch-helper to v3.17.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add multi step registration eventing (#1226) * feat: implement multi step registration experiment * feat: add multi step registration eventing * fix: fix register button width * fix: fix register button loader for control * feat: capture marketing lead in experiment events (#1243) * revert: multistep registration experiment revert multistep registration experiment changes VAN-1930 * feat: implement auto generated username experiment (#1248) * feat: implement auto generated username registration exp * feat: add page event for reset password (#1253) Description: Add page event for reset password page VAN-1929 --------- Co-authored-by: Stanislav Lunyachek <[email protected]> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]> Co-authored-by: Attiya Ishaque <[email protected]> Co-authored-by: Blue <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Syed Sajjad Hussain Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Capture the info if the user is a marketing lead (provide email with marketing opt in true) in multi step registration experiment
How Has This Been Tested?
Locally