Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump v0.10.0 #22

Closed
wants to merge 159 commits into from
Closed

Conversation

simonpasquier
Copy link

No description provided.

bwplotka and others added 30 commits October 14, 2019 14:09
)

* doc on how to disable default partial response behaviour

partial request disabling flag documented

Signed-off-by: Ivan Kiselev <[email protected]>

* extra chars in the end of the line

Signed-off-by: Ivan Kiselev <[email protected]>

* update command line params for query

Signed-off-by: Ivan Kiselev <[email protected]>

* Dot in the end

Signed-off-by: Ivan Kiselev <[email protected]>

* goddamn it whitespace

Signed-off-by: Ivan Kiselev <[email protected]>

* goddamnit whitespaces

Signed-off-by: Ivan Kiselev <[email protected]>

* final dot

Signed-off-by: Ivan Kiselev <[email protected]>
* Added CI testing against S3 bucket.

* Again, only for master/release builds and PRs from person with write-access to Thanos.

Signed-off-by: Bartek Plotka <[email protected]>

* Fixed multipart upload for S3 for smaller objects.

Signed-off-by: Bartek Plotka <[email protected]>
This commit cleans up a TODO in the flags.go file and eliminates the
regCommonServerFlags func, which added almost no additional utility
beyond calling regGRPCFlags and regHTTPAddrFlag.

Signed-off-by: Lucas Servén Marín <[email protected]>
This commit ensures that we delete the WAL after it has been flushed to
a block. Flushing the WAL simply creates a block but does not remove the
WAL directory or its contents. This means that once the DB is re-opened,
new samples are added to the same WAL. Flushing the WAL again does not
result in blocks with overlapping time ranges because the flushing logic
guards against this
(https://github.com/prometheus/prometheus/blob/master/tsdb/db.go#L300).
Nevertheless, we should delete the WAL after flushing it to ensure that
flushed samples are not needlessly re-processed. Also, once multi-TSDB
support is added, holding old samples in the WAL could cause problems.

Signed-off-by: Lucas Servén Marín <[email protected]>
…io#1660)

The current timeout while the Prometheus instance is starting up is a constant 10 minutes.
As reading the WAL can take a long time we would like to set a custom timeout value, so the Thanos
sidecar container is not erroring out every 10 minutes.

Signed-off-by: Andras Ferencz-Szabo <[email protected]>
…le (thanos-io#1656)

* Start metric and status probe server as soon as possible

Signed-off-by: Kemal Akkoyun <[email protected]>

* Update changelog

Signed-off-by: Kemal Akkoyun <[email protected]>

* Schedule a separate goroutine to start server

Signed-off-by: Kemal Akkoyun <[email protected]>

* Add InitSync to the rungroup

Signed-off-by: Kemal Akkoyun <[email protected]>

* Fix linter pointed issues

Signed-off-by: Kemal Akkoyun <[email protected]>

* Move InitSync to alreay existed run.Group

Signed-off-by: Kemal Akkoyun <[email protected]>

* Remove unnecessary changes and update CHANGELOG

Signed-off-by: Kemal Akkoyun <[email protected]>

* Add simple explanation for probes

Signed-off-by: Kemal Akkoyun <[email protected]>

* Make requested changes

Signed-off-by: Kemal Akkoyun <[email protected]>

* Update CHANGELOG.md

Co-Authored-By: Martin Chodur <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
This commit simplifies the registration of pprof HTTP endpoints. The
pprof.Index handler automatically takes care of delegating to the
correct handler for each profile depending on the request path:
https://golang.org/src/net/http/pprof/pprof.go?s=8862:9042#L260
The following profiles are handled:
https://golang.org/src/net/http/pprof/pprof.go?s=7565:8570#L248
Note that this also includes the `allocs` profile, which was previously
not explicitly added.

Signed-off-by: Lucas Servén Marín <[email protected]>
…s. (thanos-io#1666)

* Fixed compactor tests; Moved to full e2e compact test; Cleaned metrics.

Signed-off-by: Bartek Plotka <[email protected]>

* Removed block after each compaction group run.

Fixes: thanos-io#1499

Signed-off-by: Bartek Plotka <[email protected]>

* Moved to label hash for dir names for compactor groups.

Fixes: thanos-io#1661

Signed-off-by: Bartek Plotka <[email protected]>

* Addressed comments.

Signed-off-by: Bartek Plotka <[email protected]>

* Addressed comments, rebased.

Signed-off-by: Bartek Plotka <[email protected]>
…io#1675)

This will definitely helps with offset queries.

Same was done on cortexproject/cortex#1012

Signed-off-by: Bartek Plotka <[email protected]>
This small PR simply fixes an error message that confused me during a
review.

Signed-off-by: Lucas Servén Marín <[email protected]>
…sharding e2e test. (thanos-io#1669)

* store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test.

Fixes: thanos-io#1664

Signed-off-by: Bartek Plotka <[email protected]>

* Trying to speed up tests a bit.

Signed-off-by: Bartek Plotka <[email protected]>

* Fixed tests.

Signed-off-by: Bartek Plotka <[email protected]>
This commit gives the Thanos receive component the capability to use TLS
in both the remote-write client and server. This means that Thanos
receive can now authenticate all requests.

In order to accomplish this change, this commit abstracts the majority
of the logic of `defaultGRPCServerOpts` into a reusable func for gRPC
and HTTP servers and creates a similar func for TLS client
configurations.

Signed-off-by: Lucas Servén Marín <[email protected]>
* add oss support

Signed-off-by: wujinhu <[email protected]>

* fix docs

Signed-off-by: wujinhu <[email protected]>

* fix Makefile

Signed-off-by: wujinhu <[email protected]>

* review comments

Signed-off-by: wujinhu <[email protected]>

* fix style

Signed-off-by: wujinhu <[email protected]>

* review comments

Signed-off-by: wujinhu <[email protected]>

* review comments

Signed-off-by: wujinhu <[email protected]>

* review comments

Signed-off-by: wujinhu <[email protected]>

* review comments

Signed-off-by: wujinhu <[email protected]>
* Add new http-grace-period flag

Signed-off-by: Kemal Akkoyun <[email protected]>

* Update CHANGELOG

Signed-off-by: Kemal Akkoyun <[email protected]>

* Update docs

Signed-off-by: Kemal Akkoyun <[email protected]>

* Update pkg/server/http.go

Co-Authored-By: Bartlomiej Plotka <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>

* Rename initializer for HTTP server

Signed-off-by: Kemal Akkoyun <[email protected]>
Kind of annoying and easy to forget: it should be done by promu eventually. Will investigate later.


Signed-off-by: Bartek Plotka <[email protected]>
PR thanos-io#1680 introduced graceful handling for the HTTP server in Thanos, but
the graceful `Shutdown` call was being performed on an `http.Server`
instance that was *not* running at all. The actual server that was
listening for requests was started through `http.Serve`, so there was no
reference to the server struct that we could use to shut it down. This
was causing all of Thanos to freeze after receiving an exit signal,
because the run-group for the HTTP server would never finalize.

This seems like an oversight because the `(*Server).srv` field was being
properly initialized with an HTTP server. Fix this by calling
`ListenAndServe` on our initialized server.

Signed-off-by: Vicent Marti <[email protected]>
* Fix downsampling option in querier URL

Signed-off-by: Olivier Biesmans <[email protected]>

* Fix downsampling option in querier URL

Signed-off-by: Olivier Biesmans <[email protected]>
* Added experimental filesystem bucket implementation

Usa cases:
* See: observatorium/thanos-replicate#7
* Local testing, demos

Signed-off-by: Bartek Plotka <[email protected]>

* Fixed edge case.

Signed-off-by: Bartek Plotka <[email protected]>

* Disabled one test case. We cannot rely on this.

Signed-off-by: Bartek Plotka <[email protected]>
Currently, the bucket web command generates and registers metrics but
they are never actually exposed. This commit ensures that the metrics
are exposed and leverages the recently created server package for
consistency.

This cleanup also helps prepare for the upcoming changes for
thanos-io#1657.

Signed-off-by: Lucas Servén Marín <[email protected]>
bwplotka and others added 11 commits January 7, 2020 15:21
`stats` is being accessed from the goroutines inside this function so it
needs to be protected here in the same way with `mtx`. Move the house
keeping out of the inner loop into the outer one to reduce the number of
times we will need to lock/unlock the mutex.

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Change the `CHANGELOG.md` to have a proper header, the `VERSION` file,
version hashes in `tutorials/`.

Signed-off-by: Giedrius Statkevičius <[email protected]>
* Fixed crash in the memcached servers selector when there's only 1 server (thanos-io#1975)

* Fixed crash in the memcached servers selector when there's only 1 server

Signed-off-by: Marco Pracucci <[email protected]>

* Updated changelog

Signed-off-by: Marco Pracucci <[email protected]>

* Assert expected error in tests

Signed-off-by: Marco Pracucci <[email protected]>

* *: update everything for 0.10.0-rc.1

Update the version strings before the `0.10.0-rc.1` release.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Co-authored-by: Marco Pracucci <[email protected]>
* *: update for 0.10.0

Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: update date

Signed-off-by: Giedrius Statkevičius <[email protected]>
v0.10.0

Signed-off-by: Simon Pasquier <[email protected]>
@simonpasquier
Copy link
Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 15, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
Signed-off-by: Simon Pasquier <[email protected]>
@simonpasquier
Copy link
Author

/assign @bwplotka @squat

I presume there's nothing blocking us from updating the Thanos components to v0.10.0

@s-urbaniak
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [s-urbaniak,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak
Copy link

let's leave this on hold until thanos-io#2015 is resolved.

@simonpasquier
Copy link
Author

After discussing offline with @s-urbaniak it appears that we don't really the bump for now since v0.10.0 doesn't bring all what we need for multi-tenancy alerting.

@simonpasquier simonpasquier deleted the bump-v0.10.0 branch January 23, 2020 14:28
@pgier pgier mentioned this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.