Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #62. Creates a GUI for tethys #118

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Addresses #62. Creates a GUI for tethys #118

merged 12 commits into from
Dec 15, 2021

Conversation

arjo129
Copy link
Member

@arjo129 arjo129 commented Dec 15, 2021

Closes #62

TBH this is kind of ugly (I failed art in primary school), but this PR creates a GUI for all the control surfaces of the LRAUV.

tethys_gui

Feedback is welcome. Still trying to learn QML properly (thank god I'm not a front end dev).

Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
@chapulina chapulina self-requested a review December 15, 2021 16:34
Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 self-assigned this Dec 15, 2021
Signed-off-by: Louise Poubel <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it's so much easier to use than the keyboard teleop!

Future feature request: it would be good to update the values on the GUI from the state message, so that when we change the vehicle name, the GUI is updated to the current values for that vehicle.

TBH this is kind of ugly

I figured you wouldn't mind some help with the layout, so I pushed directly to this branch on 6bc2a2f 😉

tethysgui

@chapulina chapulina merged commit bfdffb7 into main Dec 15, 2021
@chapulina chapulina deleted the arjo/feature/gui branch December 15, 2021 21:17
@mabelzhang
Copy link
Collaborator

mabelzhang commented Dec 17, 2021

Just saw this while reviewing the Garden PR and hunted it down here. This is so useful!!!! And fun. Thanks for adding it!!

@mabelzhang
Copy link
Collaborator

mabelzhang commented Dec 17, 2021

I think we should add something like this to the ign-gazebo list of tutorials here https://ignitionrobotics.org/api/gazebo/6.3/tutorials.html
It'd need an example robot (maybe the model upstream is good enough?)

The control panel is a very good idea and great for general robotics entry-level learning of what a robot can do, by moving its joints. It could be part of the suite of beginner tutorials to Ignition (when we have those tutorial labels).

@arjo129
Copy link
Member Author

arjo129 commented Dec 17, 2021 via email

@mabelzhang
Copy link
Collaborator

mabelzhang commented Dec 17, 2021

@braanan Have you seen @arjo129's new plugin panel with sliders for the actuator controls? It's so nice!! It adds much more visual understanding and user interaction. I’d propose including it in your periodic report’s highlights.

I love this video game haha it's so fun.

My abstract (ramen?) art using rudder, elevator, thruster, VBS, and finally drop weight (didn't use mass shifter, oh well):

2021-12-17-032209_2400x2000_scrot_ControlPanelPlugin
2021-12-17-032227_2400x2000_scrot

Video of its creation (see 00:43 for sudden change in thruster, and 1:47 for drop weight):

out-1.mp4

@braanan
Copy link
Collaborator

braanan commented Dec 17, 2021

Very cool! Thanks for the hard work @arjo129!

@braanan
Copy link
Collaborator

braanan commented Dec 17, 2021

Just played around with this new feature - it's super nice! I think we can integrate it nicely with our operator training program to help pilots develop intuition for the how the vehicle responds to the actuators. One minor suggestion is to display the units in degrees and rpm instead of radians - those units might be more intuitive for end users.

@mabelzhang
Copy link
Collaborator

mabelzhang commented Dec 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tethys control GUI
4 participants