Ported tiles to empty world #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <[email protected]>
hidmic
approved these changes
Jun 21, 2022
| add_custom_command( | ||
| OUTPUT world_gen_cmd | ||
| COMMAND python3 ${CMAKE_CURRENT_SOURCE_DIR}/worlds/empy_expander.py | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/worlds/${WORLD_NAME}.sdf.em | ||
| ${CMAKE_CURRENT_BINARY_DIR}/worlds/${WORLD_NAME}.sdf | ||
| COMMAND python3 ${CMAKE_CURRENT_SOURCE_DIR}/worlds/empy_expander.py | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/worlds/${WORLD_NAME_EMPTY}.sdf.em | ||
| ${CMAKE_CURRENT_BINARY_DIR}/worlds/${WORLD_NAME_EMPTY}.sdf |
There was a problem hiding this comment.
@adityapande-1995 meta: at some point, it would be nice to have a macro to set up SDF template expansion during builds.
| <plugin | ||
| filename="ignition-gazebo-physics-system" | ||
| name="gz::sim::systems::Physics"> | ||
| </plugin> |
There was a problem hiding this comment.
@adityapande-1995 meta: we duplicate a lot across worlds' definitions. At some point, it may be worth exploring having a hierarchy of templates instead.
|
Tested locally, this one is working. The CI is failing due to porting of macros, which has been done in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya [email protected]
This PR ports the Portuguese ledge tiles to a copy of the
empty_environment.sdf, calledempty_environment_with_tiles.sdf.em