perf(linter/no-unused-vars): use default IgnorePattern when /^_/ is provided as a pattern #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #6697 will not alter performanceComparing Summary
|
camchenry
approved these changes
Oct 20, 2024
Merge activity
|
DonIsaac
force-pushed
the
don/10-19-feat_linter/eslint_show_ignore_patterns_in_eslint/no-unused-vars_diagnostic_messages
branch
from
6289632 to
01a35bb
Compare
Base automatically changed from
don/10-19-feat_linter/eslint_show_ignore_patterns_in_eslint/no-unused-vars_diagnostic_messages
to
main
October 20, 2024 04:28
DonIsaac
force-pushed
the
don/10-19-perf_linter/no-unused-vars_use_default_ignorepattern_when_/__/_is_provided_as_a_pattern
branch
from
159fe13 to
7328e52
Compare
…rovided as a pattern (#6697) Use `IgnorePattern::Default` even when `/^_/` is explicitly provided as a regex. This gives better diagnostic messages and lets us use `starts_with('_')` in more cases.
DonIsaac
force-pushed
the
don/10-19-perf_linter/no-unused-vars_use_default_ignorepattern_when_/__/_is_provided_as_a_pattern
branch
from
7328e52 to
6a76ea8
Compare
graphite-app
bot
deleted the
don/10-19-perf_linter/no-unused-vars_use_default_ignorepattern_when_/__/_is_provided_as_a_pattern
branch
Boshen
added a commit
that referenced
this pull request
Oct 21, 2024
## [0.10.1] - 2024-10-21 ### Features - af25752 linter: Add `unicorn/prefer-math-min-max` (#6621) (Brian Liu) - 5095f02 linter: Added fixer for duplicate prefix in valid title jest rule (#6699) (Tapan Prakash) - e9976d4 linter: Add title whitespace fixer for jest valid title rule (#6669) (Tapan Prakash) - 45f02d5 linter: Add `unicorn/consistent-empty-array-spread` (#6695) (Brian Liu) - 01a35bb linter/eslint: Show ignore patterns in `eslint/no-unused-vars` diagnostic messages (#6696) (DonIsaac) ### Bug Fixes - 1bcd707 editor: Update config sent to language server (#6724) (Nicholas Rayburn) - ce25c45 linter: Panic in `disable-directives` (#6677) (dalaoshu) - a5de230 linter/import: `import/no-duplicates` handles namespace imports correctly (#6694) (DonIsaac) - b0b6ac7 linter/no-cond-assign: False positive when assignment is in body statement (#6665) (camchenry) ### Performance - 6a76ea8 linter/no-unused-vars: Use default IgnorePattern when /^_/ is provided as a pattern (#6697) (DonIsaac) ### Refactor - d6609e9 linter: Use `run_on_jest_node` for existing lint rules (#6722) (camchenry) - 97195ec linter: Add `run_on_jest_node` to run rules on only jest nodes (#6721) (camchenry) - 155fe7e linter: Allow `Semantic` to be passed for collecting Jest nodes (#6720) (camchenry) - ad8f281 linter: Use iter for collecting jest nodes (#6719) (camchenry) - dc19a8f linter: Use iterator for collecting jest imports (#6718) (camchenry) - 29c1447 linter: `jest/valid-title` fixer to use `Span::shrink` method (#6703) (Tapan Prakash) - 2eb984a linter: Add missing `should_run` implementations (#6666) (camchenry) - 23f88b3 linter/import: Better diagnostic messages for `import/no-duplicates` (#6693) (DonIsaac) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
IgnorePattern::Defaulteven when/^_/is explicitly provided as a regex. This gives better diagnostic messages and lets us usestarts_with('_')in more cases.