refactor(linter): use run_on_jest_node for existing lint rules

[camchenry]

• closes linter: duplicate work in Jest/Vitest rules #6038

Migrates all simple iterations over Jest nodes to use the run_on_jest_node method. Rules which require more custom data (such as getting nodes in order or storing data about counts, duplicates, etc.) have not been migrated.

Some simple benchmarking shows that this is ~5% faster on vscode when the Jest/Vitest rules are NOT enabled (due to being able to skip them now). And it is up to 8% on vscode when the Jest/Vitest plugins are enabled.

hyperfine -i -N --warmup 3 --runs 30 './oxlint-jest-iter --deny=all --silent ./vscode' './oxlint-main --deny=all --silent ./vscode' 
Benchmark 1: ./oxlint-jest-iter --deny=all --silent ./vscode
  Time (mean ± σ):      2.348 s ±  0.104 s    [User: 16.922 s, System: 0.641 s]
  Range (min … max):    2.141 s …  2.544 s    30 runs
 
Benchmark 2: ./oxlint-main --deny=all --silent ./vscode
  Time (mean ± σ):      2.476 s ±  0.042 s    [User: 17.768 s, System: 0.668 s]
  Range (min … max):    2.430 s …  2.598 s    30 runs
 
Summary
  ./oxlint-jest-iter --deny=all --silent ./vscode ran
    1.05 ± 0.05 times faster than ./oxlint-main --deny=all --silent ./vscode

hyperfine -i -N --warmup 3 --runs 30 './oxlint-jest-iter --deny=all --jest-plugin --vitest-plugin --silent ./vscode' './oxlint-main --deny=all --jest-plugin --vitest-plugin --silent ./vscode'
Benchmark 1: ./oxlint-jest-iter --deny=all --jest-plugin --vitest-plugin --silent ./vscode
  Time (mean ± σ):      2.728 s ±  0.118 s    [User: 19.782 s, System: 0.786 s]
  Range (min … max):    2.580 s …  3.078 s    30 runs
 
Benchmark 2: ./oxlint-main --deny=all --jest-plugin --vitest-plugin --silent ./vscode
  Time (mean ± σ):      2.939 s ±  0.051 s    [User: 21.259 s, System: 0.859 s]
  Range (min … max):    2.848 s …  3.064 s    30 runs
 
Summary
  ./oxlint-jest-iter --deny=all --jest-plugin --vitest-plugin --silent ./vscode ran
    1.08 ± 0.05 times faster than ./oxlint-main --deny=all --jest-plugin --vitest-plugin --silent ./vscode

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[camchenry]

• refactor(linter): use run_on_jest_node for existing lint rules #6722 👈
• refactor(linter): add run_on_jest_node to run rules on only jest nodes #6721
• refactor(linter): allow Semantic to be passed for collecting Jest nodes #6720
• refactor(linter): use iter for collecting jest nodes #6719
• refactor(linter): use iterator for collecting jest imports #6718
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6722 will not alter performance

_{Comparing 10-20-refactor_linter_use_run_on_jest_node_for_existing_lint_rules (d6609e9) with main (bad8770)}

Summary

✅ 30 untouched benchmarks

[camchenry]

Nice, performance looks better:

[Boshen]

Merge activity

• Oct 20, 10:05 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 20, 10:05 PM EDT: A user added this pull request to the Graphite merge queue.
• Oct 20, 10:36 PM EDT: A user merged this pull request with the Graphite merge queue.