Merge pull request #705 from mfocko/fix-pagure-from-url

fix(pagure): raise for invalid URL in pagure When using PagureService.get_project_from_url test for correctly parsed URL before accessing its attributes (resulting in AttributeError). Fixes #698 Signed-off-by: Matej Focko [email protected] RELEASE NOTES BEGIN ogr now correctly raises OgrException when given invalid URL to PagureService.get_project_from_url. RELEASE NOTES END Reviewed-by: Jiri Popelka <None>
packit · Apr 27, 2022 · 0ef457d · 0ef457d
2 parents 034c5d0 + 6073253
commit 0ef457d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/ogr/services/pagure/service.py b/ogr/services/pagure/service.py
@@ -100,6 +100,9 @@ def get_project(self, **kwargs) -> "PagureProject":
 
     def get_project_from_url(self, url: str) -> "PagureProject":
         repo_url = parse_git_repo(potential_url=url)
+        if not repo_url:
+            raise OgrException(f"Cannot parse project url: '{url}'")
+
         if not repo_url.is_fork:
             repo_url.username = None