Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeError: when repo_url.is_fork called as repo_url can return NoneType #698

Closed
daeisbae opened this issue Apr 8, 2022 · 0 comments · Fixed by #705
Closed

AttributeError: when repo_url.is_fork called as repo_url can return NoneType #698

daeisbae opened this issue Apr 8, 2022 · 0 comments · Fixed by #705
Assignees
@mfocko
Labels
kind/bug Something isn't working.

Comments

@daeisbae
Copy link

daeisbae commented Apr 8, 2022 •
edited
Loading

ogr/ogr/services/pagure/service.py

Line 101 in c6bf9ae

def get_project_from_url(self, url: str) -> "PagureProject":

ogr/ogr/parsing.py

Line 202 in c6bf9ae

def parse_git_repo(potential_url: str) -> Optional[RepoUrl]:

"parse_git_repo" function's return value is returned to repo_url variable which is used by "get_project_from_url" function, however "parse_git_repo" function can return NoneType causing AttributeError
@mfocko mfocko added the kind/bug Something isn't working. label Apr 27, 2022
@mfocko mfocko self-assigned this Apr 27, 2022
mfocko added a commit to mfocko/ogr that referenced this issue Apr 27, 2022
@mfocko
fix(pagure): raise for invalid URL in pagure
6073253 
When using `PagureService.get_project_from_url` test for correctly parsed
URL before accessing its attributes (resulting in `AttributeError`).

Fixes packit#698

Signed-off-by: Matej Focko <[email protected]>
@mfocko mfocko mentioned this issue Apr 27, 2022
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Apr 27, 2022
@softwarefactory-project-zuul
Merge pull request #705 from mfocko/fix-pagure-from-url
0ef457d 
fix(pagure): raise for invalid URL in pagure

When using PagureService.get_project_from_url test for correctly parsed
URL before accessing its attributes (resulting in AttributeError).
Fixes #698
Signed-off-by: Matej Focko [email protected]
RELEASE NOTES BEGIN
ogr now correctly raises OgrException when given invalid URL to PagureService.get_project_from_url.
RELEASE NOTES END

Reviewed-by: Jiri Popelka <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfocko mfocko

Labels
kind/bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pagure): raise for invalid URL in pagure mfocko/ogr
2 participants
@mfocko @daeisbae