fix(pagure): raise for invalid URL in pagure #705
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `PagureService.get_project_from_url` test for correctly parsed URL before accessing its attributes (resulting in `AttributeError`). Fixes packit#698 Signed-off-by: Matej Focko <[email protected]>
|
Build succeeded.
|
jpopelka
approved these changes
Apr 27, 2022
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
PagureService.get_project_from_urltest for correctly parsedURL before accessing its attributes (resulting in
AttributeError).Fixes #698
Signed-off-by: Matej Focko [email protected]
RELEASE NOTES BEGIN
ogrnow correctly raisesOgrExceptionwhen given invalid URL toPagureService.get_project_from_url.RELEASE NOTES END