[IOAPPX-324] Fix HeaderSecondLevel UI regression
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
approved these changes
Jun 18, 2024
dmnplb
added a commit
to pagopa/io-app
that referenced
this pull request
Sep 27, 2024
…h the new DS components (#5869) > [!warning] > This PR depends on: > * pagopa/io-app-design-system#290 > * pagopa/io-app-design-system#291 > * pagopa/io-app-design-system#294 ## Short description This PR updates the entire `Assistance` section with the new DS components. ## List of changes proposed in this pull request - Remove `BaseScreenComponent` from existent screens - Handle the different headers with `react-navigation` - Add the new components, like `FooterActions` or `IOScrollViewWithLargeHeader` to replace the legacy components - Use `FlatList` with appropriate `ListItem…` or `AccordionItem` components instead of `.map()` and custom components - Update `IOScrollViewWithLargeHeader` to include a section reference above the title - Use `OperationResultScreenContent` to render the empty state when there are no open requests - Remove legacy `IdpCustomContextualHelpContent` component ### Open issues - `PanicMode` and other error screens still do not have updates ### Preview | First page | Choose category | Ask permissions | |--------|--------|--------| | <video src="https://github.com/pagopa/io-app/assets/1255491/07d113be-262d-4245-84e0-a72b143a372d" /> | <video src="https://github.com/pagopa/io-app/assets/1255491/771a2b69-9413-4d8d-b4ce-8d6f84c06dda" /> | <video src="https://github.com/pagopa/io-app/assets/1255491/bf74fc8e-3ac9-4cd4-b729-0056755c93c2" /> | ## How to test Test different **Assistance** flows from different sections --------- Co-authored-by: Fabio Bombardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR fixes the
HeaderSecondLevelUI regression, introduced by mistake with the following PR:contrastvariant and optionalbackgroundColorprop toHeaderSecondLevel#285The problem
List of changes proposed in this pull request
animatedStylein all the conditionsPreview
(Please look at the header's bottom border)
beforeFix.mp4
afterFix.mp4
How to test
HeaderSecondLevel