Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-329] Fix chromatic values of the AccordionItem component #294

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jun 24, 2024

Short description

This PR fixes the wrong chromatic values of the AccordionItem component

List of changes proposed in this pull request

  • Add theme-based keys to the component to fix the chevron set with hardcoded blueIO-500 value
  • Add (temporary) dark mode support
  • [extra]: Fix wrong border color of ModuleAttachment

Preview

accordion-item-fix.mp4

How to test

  1. Run the example app
  2. Check Accordion screen

@dmnplb dmnplb merged commit 522fc78 into main Jun 26, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-329-fix-chevron-color-accordion branch June 26, 2024 13:20
dmnplb added a commit to pagopa/io-app that referenced this pull request Sep 27, 2024
…h the new DS components (#5869)

> [!warning]
> This PR depends on:
> * pagopa/io-app-design-system#290
> * pagopa/io-app-design-system#291
> * pagopa/io-app-design-system#294

## Short description
This PR updates the entire `Assistance` section with the new DS
components.

## List of changes proposed in this pull request
- Remove `BaseScreenComponent` from existent screens
- Handle the different headers with `react-navigation`
- Add the new components, like `FooterActions` or
`IOScrollViewWithLargeHeader` to replace the legacy components
- Use `FlatList` with appropriate `ListItem…` or `AccordionItem`
components instead of `.map()` and custom components
- Update `IOScrollViewWithLargeHeader` to include a section reference
above the title
- Use `OperationResultScreenContent` to render the empty state when
there are no open requests
- Remove legacy `IdpCustomContextualHelpContent` component

### Open issues
-  `PanicMode` and other error screens still do not have updates

### Preview
| First page | Choose category | Ask permissions |
|--------|--------|--------|
| <video
src="https://github.com/pagopa/io-app/assets/1255491/07d113be-262d-4245-84e0-a72b143a372d"
/> | <video
src="https://github.com/pagopa/io-app/assets/1255491/771a2b69-9413-4d8d-b4ce-8d6f84c06dda"
/> | <video
src="https://github.com/pagopa/io-app/assets/1255491/bf74fc8e-3ac9-4cd4-b729-0056755c93c2"
/> |


## How to test
Test different **Assistance** flows from different sections

---------

Co-authored-by: Fabio Bombardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants