chore(Cross): [IOAPPX-322] Update the entire Assistance section with the new DS components

[dmnplb]

Warning

This PR depends on:

• [IOAPPX-323] Remove mandatory id prop from AccordionItem io-app-design-system#290
• [IOAPPX-324] Fix HeaderSecondLevel UI regression io-app-design-system#291
• [IOAPPX-329] Fix chromatic values of the AccordionItem component io-app-design-system#294

Short description

This PR updates the entire Assistance section with the new DS components.

List of changes proposed in this pull request

• Remove BaseScreenComponent from existent screens
• Handle the different headers with react-navigation
• Add the new components, like FooterActions or IOScrollViewWithLargeHeader to replace the legacy components
• Use FlatList with appropriate ListItem… or AccordionItem components instead of .map() and custom components
• Update IOScrollViewWithLargeHeader to include a section reference above the title
• Use OperationResultScreenContent to render the empty state when there are no open requests
• Remove legacy IdpCustomContextualHelpContent component

Open issues

• PanicMode and other error screens still do not have updates

Preview

First page	Choose category	Ask permissions
ZendeskFirstPage.mp4	ZChooseCategory.mp4	ZAskPermissions.mp4

How to test

Test different Assistance flows from different sections

[pagopa-github-bot]

Affected stories

• ⚙️ IOAPPX-322: Aggiornamento della sezione Assistenza con componenti del nuovo DS

Generated by 🚫 dangerJS against 03cae50

[dmnplb]

@shadowsheep1 Thanks for the review. I have made some progress:

• Removed all the comments → d35e588
• Removed all the legacy components from ZendeskSeeReportsRouters using the new LoadingScreenContent and OperationResultScreenContent → ca1a4a1

Panic mode screen's still have the old UI

Replaced the legacy component with OperationResultScreenContent → c56256d

It seems that in the first screen, in the actions footer, the solid button overflow the blank footer area. Am I right?

It's FooterActions if it's fixed and not managed by IOScrollView. I didn't use it at first because I needed a special header, but I realised that I could still use useLayoutEffect with IOScrollView. So I made the change in the following commit → 385a460

Sadly, there are still open issues:

• Some tests are still failing
• I don't know if we always have to signal the end of the flow (trough workUnitComplete), even when the user taps an external link
• There's a type mismatch in the IdpLoginScreen component, caused by the custom components injected in that specific case and not correctly handled by TS

Preview

Here's a preview of the main screen using IOScrollView:

assistanceHeaderPreview.mp4

[shadowsheep1]

LGTM.

For the markdown part, it's right how this new implementation render it, because what's wrong is the markdown itself coming from io-services-metadata (only the EN and DE part).

[codecov]

Codecov Report

Attention: Patch coverage is 48.80000% with 64 lines in your changes missing coverage. Please review.

Project coverage is 47.02%. Comparing base (4f204b4) to head (03cae50).
Report is 521 commits behind head on master.

Files with missing lines	Patch %	Lines
...endesk/screens/ZendeskAskSeeReportsPermissions.tsx	0.00%	12 Missing ⚠️
...tures/zendesk/screens/ZendeskSeeReportsRouters.tsx	0.00%	11 Missing ⚠️
...s/components/screens/BaseScreenComponent/index.tsx	62.96%	10 Missing ⚠️
...tures/zendesk/screens/ZendeskSupportHelpCenter.tsx	71.87%	9 Missing ⚠️
...features/zendesk/screens/ZendeskChooseCategory.tsx	27.27%	8 Missing ⚠️
...tures/zendesk/screens/ZendeskChooseSubCategory.tsx	37.50%	5 Missing ⚠️
...s/screens/authentication/idpAuthSessionHandler.tsx	0.00%	4 Missing ⚠️
...features/zendesk/screens/ZendeskAskPermissions.tsx	76.92%	3 Missing ⚠️
ts/features/design-system/navigation/navigator.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5869      +/-   ##
==========================================
- Coverage   48.42%   47.02%   -1.41%     
==========================================
  Files        1488     1760     +272     
  Lines       31617    35625    +4008     
  Branches     7669     8558     +889     
==========================================
+ Hits        15311    16753    +1442     
- Misses      16238    18806    +2568     
+ Partials       68       66       -2     

Files with missing lines	Coverage Δ
...s/components/screens/BaseScreenComponent/utils.tsx	71.42% <ø> (+3.24%)	⬆️
ts/components/ui/IOScrollView.tsx	86.11% <100.00%> (ø)
ts/components/ui/IOScrollViewWithLargeHeader.tsx	78.57% <100.00%> (ø)
.../features/design-system/core/DSLegacyListItems.tsx	71.42% <ø> (ø)
ts/features/zendesk/navigation/navigator.tsx	66.66% <ø> (ø)
ts/features/zendesk/screens/ZendeskPanicMode.tsx	100.00% <ø> (ø)
ts/navigation/AuthenticatedStackNavigator.tsx	15.00% <ø> (+3.88%)	⬆️
ts/navigation/NotAuthenticatedStackNavigator.tsx	66.66% <ø> (ø)
ts/screens/authentication/IdpLoginScreen.tsx	1.94% <ø> (-2.06%)	⬇️
ts/utils/emptyContextualHelp.tsx	100.00% <ø> (+50.00%)	⬆️
... and 9 more

... and 1314 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8833776...03cae50. Read the comment docs.