Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-238] IDPAY CODE onboarding flow Xstate and flow basics #4976

Closed
wants to merge 10 commits into from

Conversation

forrest57
Copy link
Contributor

@forrest57 forrest57 commented Sep 13, 2023

Short description

Addition of Xstate and navigation basics for IDPAY CODE's onboarding flow

List of changes proposed in this pull request

  • addition of xstate:
  1. machine definition
  2. actions
  3. provider
  4. services
  5. context definition file
  6. single guard
    -- it is all mocks, so a lot will have to be rewritten, this PR consists in a boilerplate to avoid future merge conflicts --
  • Addition of navigator

How to test

since no real feature is implemented, there is no way to test 😅
Read the code and run tsc and prettier, it should be good enough.
once more, keep in mind once again that this is a skeleton made to base the future PRs on on order to have the same folder and naming structures, plus avoid writing boilerplate in every PR

@forrest57 forrest57 temporarily deployed to dev September 13, 2023 10:31 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [IOBP-238] IDPAY CODE onboarding flow Xstate and flow basics chore: [IOBP-238] IDPAY CODE onboarding flow Xstate and flow basics Sep 13, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 13, 2023

Affected stories

  • ⚙️ IOBP-238: Implementazione flusso xstate
    subtask of
    • IOBP-213: [MVP] IO-IDPay - Pagamento tramite CIE

Generated by 🚫 dangerJS against eff7814

@forrest57 forrest57 temporarily deployed to dev September 14, 2023 09:20 — with GitHub Actions Inactive
@forrest57 forrest57 temporarily deployed to dev September 14, 2023 09:46 — with GitHub Actions Inactive
@forrest57 forrest57 marked this pull request as ready for review September 14, 2023 09:47
@forrest57 forrest57 requested a review from a team as a code owner September 14, 2023 09:47
@forrest57 forrest57 added IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #4976 (a2e2243) into master (3703fa5) will decrease coverage by 0.04%.
The diff coverage is 25.53%.

❗ Current head a2e2243 differs from pull request most recent head eff7814. Consider uploading reports for the commit eff7814 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4976      +/-   ##
==========================================
- Coverage   47.51%   47.48%   -0.04%     
==========================================
  Files        1590     1596       +6     
  Lines       31870    31917      +47     
  Branches     8138     8139       +1     
==========================================
+ Hits        15143    15155      +12     
- Misses      16657    16692      +35     
  Partials       70       70              
Files Changed Coverage Δ
ts/navigation/AuthenticatedStackNavigator.tsx 9.09% <ø> (ø)
ts/screens/profile/ProfileMainScreen.tsx 3.08% <ø> (ø)
ts/features/idpay/codeOnboarding/xstate/actions.ts 7.69% <7.69%> (ø)
.../features/idpay/codeOnboarding/xstate/provider.tsx 20.00% <20.00%> (ø)
...s/features/idpay/codeOnboarding/xstate/services.ts 20.00% <20.00%> (ø)
ts/features/idpay/codeOnboarding/xstate/machine.ts 33.33% <33.33%> (ø)
ts/features/idpay/codeOnboarding/navigation.tsx 80.00% <80.00%> (ø)
ts/features/idpay/codeOnboarding/xstate/context.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3703fa5...eff7814. Read the comment docs.

@forrest57 forrest57 temporarily deployed to dev September 14, 2023 10:29 — with GitHub Actions Inactive
@Hantex9 Hantex9 temporarily deployed to dev September 15, 2023 07:08 — with GitHub Actions Inactive
Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a boilerplate to build other features, LGTM!

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will code feature need other sub-features? Maybe ts/features/idpay/code/onboarding would be better

}
}
},
SHOWING_PIN: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SHOWING_PIN: {
DISPLAYING_PIN: {

@mastro993
Copy link
Contributor

Switched to Redux-Saga #4995

@mastro993 mastro993 closed this Sep 25, 2023
@dmnplb dmnplb deleted the IOBP-238-idpay-cie-onboarding-xstate-flow branch September 25, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants