-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOBP-238] IDPAY CODE onboarding flow Xstate and flow basics #4976
Conversation
…ithub.com/pagopa/io-app into IOBP-238-idpay-cie-onboarding-xstate-flow
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4976 +/- ##
==========================================
- Coverage 47.51% 47.48% -0.04%
==========================================
Files 1590 1596 +6
Lines 31870 31917 +47
Branches 8138 8139 +1
==========================================
+ Hits 15143 15155 +12
- Misses 16657 16692 +35
Partials 70 70
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a boilerplate to build other features, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will code
feature need other sub-features? Maybe ts/features/idpay/code/onboarding
would be better
} | ||
} | ||
}, | ||
SHOWING_PIN: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHOWING_PIN: { | |
DISPLAYING_PIN: { |
Switched to Redux-Saga #4995 |
Short description
Addition of Xstate and navigation basics for IDPAY CODE's onboarding flow
List of changes proposed in this pull request
-- it is all mocks, so a lot will have to be rewritten, this PR consists in a boilerplate to avoid future merge conflicts --
How to test
since no real feature is implemented, there is no way to test 😅
Read the code and run tsc and prettier, it should be good enough.
once more, keep in mind once again that this is a skeleton made to base the future PRs on on order to have the same folder and naming structures, plus avoid writing boilerplate in every PR