Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network refactoring #22

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Network refactoring #22

merged 1 commit into from
Oct 18, 2021

Conversation

uolter
Copy link
Member

@uolter uolter commented Oct 18, 2021

List of changes

There is not need to use a dedicated vnet for the apim, thought the peering is not needed too!!
Keep it simple!!
Probably you need to delete the apim before.

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@uolter uolter requested a review from antonioT90 as a code owner October 18, 2021 16:34
@uolter uolter requested a review from a team October 18, 2021 16:34
@uolter uolter changed the title Network refactoting Network refactoring Oct 18, 2021
@antonioT90 antonioT90 merged commit 9020c6a into main Oct 18, 2021
@antonioT90 antonioT90 deleted the networking-refactoring branch October 18, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants