Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network refactoring #22

Merged
merged 1 commit into from
Oct 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/apim.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module "apim_snet" {
source = "git::https://github.com/pagopa/azurerm.git//subnet?ref=v1.0.58"
name = format("%s-apim-snet", local.project)
resource_group_name = azurerm_resource_group.rg_vnet.name
virtual_network_name = module.vnet_integration.name
virtual_network_name = module.vnet.name
address_prefixes = var.cidr_subnet_apim

enforce_private_link_endpoint_network_policies = true
Expand Down
22 changes: 1 addition & 21 deletions src/core/dns_private.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ resource "azurerm_private_dns_zone_virtual_network_link" "privatelink_documents_
tags = var.tags
}

resource "azurerm_private_dns_zone_virtual_network_link" "privatelink_documents_azure_com_vnet_integration" {
name = module.vnet_integration.name
resource_group_name = azurerm_resource_group.rg_vnet.name
private_dns_zone_name = azurerm_private_dns_zone.privatelink_documents_azure_com.name
virtual_network_id = module.vnet_integration.id
registration_enabled = false

tags = var.tags
}

resource "azurerm_private_dns_zone" "privatelink_mongo_cosmos_azure_com" {
name = "privatelink.mongo.cosmos.azure.com"
resource_group_name = azurerm_resource_group.rg_vnet.name
Expand All @@ -40,14 +30,4 @@ resource "azurerm_private_dns_zone_virtual_network_link" "privatelink_mongo_cosm
registration_enabled = false

tags = var.tags
}

resource "azurerm_private_dns_zone_virtual_network_link" "privatelink_mongo_cosmos_azure_com_vnet_integration" {
name = module.vnet_integration.name
resource_group_name = azurerm_resource_group.rg_vnet.name
private_dns_zone_name = azurerm_private_dns_zone.privatelink_mongo_cosmos_azure_com.name
virtual_network_id = module.vnet_integration.id
registration_enabled = false

tags = var.tags
}
}
6 changes: 1 addition & 5 deletions src/core/env/dev/terraform.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@ cidr_subnet_redis = ["10.1.132.0/24"]
cidr_subnet_vpn = ["10.1.133.0/24"]
cidr_subnet_dnsforwarder = ["10.1.134.0/29"]
cidr_subnet_cosmosdb_mongodb = ["10.1.135.0/24"]

# integration vnet
# https://www.davidc.net/sites/default/subnets/subnets.html?network=10.230.7.0&mask=24&division=7.31
cidr_vnet_integration = ["10.230.7.0/24"] # ask to SIA
cidr_subnet_apim = ["10.230.7.0/26"]
cidr_subnet_apim = ["10.1.136.0/24"]

# dns
external_domain = "pagopa.it"
Expand Down
6 changes: 1 addition & 5 deletions src/core/env/prod/terraform.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@ cidr_subnet_redis = ["10.1.132.0/24"]
cidr_subnet_vpn = ["10.1.133.0/24"]
cidr_subnet_dnsforwarder = ["10.1.134.0/29"]
cidr_subnet_cosmosdb_mongodb = ["10.1.135.0/24"]

# integration vnet
# https://www.davidc.net/sites/default/subnets/subnets.html?network=10.230.7.0&mask=24&division=7.31
cidr_vnet_integration = ["10.230.7.0/24"] # todo ask to SIA
cidr_subnet_apim = ["10.230.7.0/26"]
cidr_subnet_apim = ["10.1.136.0/24"]

# dns
external_domain = "pagopa.it"
Expand Down
5 changes: 1 addition & 4 deletions src/core/env/uat/terraform.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,8 @@ cidr_subnet_redis = ["10.1.132.0/24"]
cidr_subnet_vpn = ["10.1.133.0/24"]
cidr_subnet_dnsforwarder = ["10.1.134.0/29"]
cidr_subnet_cosmosdb_mongodb = ["10.1.135.0/24"]
cidr_subnet_apim = ["10.1.136.0/24"]

# integration vnet
# https://www.davidc.net/sites/default/subnets/subnets.html?network=10.230.7.0&mask=24&division=7.31
cidr_vnet_integration = ["10.230.7.0/24"] # todo ask to SIA
cidr_subnet_apim = ["10.230.7.0/26"]

# dns
external_domain = "pagopa.it"
Expand Down
26 changes: 0 additions & 26 deletions src/core/network.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,6 @@ module "vnet" {
tags = var.tags
}

# vnet integration
module "vnet_integration" {
source = "git::https://github.com/pagopa/azurerm.git//virtual_network?ref=v1.0.58"
name = format("%s-vnet-integration", local.project)
location = azurerm_resource_group.rg_vnet.location
resource_group_name = azurerm_resource_group.rg_vnet.name
address_space = var.cidr_vnet_integration

tags = var.tags
}

## Peering between the vnet(main) and integration vnet
module "vnet_peering" {
source = "git::https://github.com/pagopa/azurerm.git//virtual_network_peering?ref=v1.0.58"

location = azurerm_resource_group.rg_vnet.location

source_resource_group_name = azurerm_resource_group.rg_vnet.name
source_virtual_network_name = module.vnet.name
source_remote_virtual_network_id = module.vnet.id
source_allow_gateway_transit = true # needed by vpn gateway for enabling routing from vnet to vnet_integration
target_resource_group_name = azurerm_resource_group.rg_vnet.name
target_virtual_network_name = module.vnet_integration.name
target_remote_virtual_network_id = module.vnet_integration.id
target_use_remote_gateways = false # needed by vnet peering with SIA
}

## VPN subnet
module "vpn_snet" {
Expand Down
8 changes: 0 additions & 8 deletions src/core/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@ output "vnet_address_space" {
value = module.vnet.address_space
}

output "vnet_integration_name" {
value = module.vnet_integration.name
}

output "vnet_integration_address_space" {
value = module.vnet_integration.address_space
}

## Redis cache
output "redis_primary_access_key" {
value = module.redis.primary_access_key
Expand Down
5 changes: 0 additions & 5 deletions src/core/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -379,11 +379,6 @@ variable "cidr_vnet" {
description = "Virtual network address space."
}

variable "cidr_vnet_integration" {
type = list(string)
description = "Virtual network to peer with sia subscription. It should host apim"
}

variable "cidr_subnet_apim" {
type = list(string)
description = "Address prefixes subnet api management."
Expand Down