Duplicate utils.js code in integration-test and parcel-bundler. #2604
Labels
Comments
3 tasks
|
I think the goal is to get as much test utils as possible into test-utils so we don’t have too much duplicate code and plugins can just do integration tests with the same package we use internally Sent with GitHawk |
sainthkh
added a commit
to sainthkh/parcel
that referenced
this issue
Feb 1, 2019
…s into test-utils/src/utils.js. (parcel-bundler#2604)
DeMoorJasper
pushed a commit
that referenced
this issue
Feb 3, 2019
#2605) * Ignore Kotlin tests and show messages when Java is not installed or configured. (#2603) * Skip symlink tests and show warning message when tests are run without admin privilege. (#2602) * Moved parcel-bundler/test/utils.js and integration-tests/test/utils.js into test-utils/src/utils.js. (#2604) * Fixed eslint errors. * Use the test to assert this.child.killed rather than checking time difference. (#2609) (#2612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
❔ Question
The codes in
/integration-test/test/utils.jsand/parcel-bundler/test/utils.jsare identical without the first line that requiresBundler.And
test-utilsmodule has only one functionsleep. Isn't it better to merge these 2 files intotest-utils?🔦 Context
When I was writing code for #2590, I first added my error message function
symlinkPrivilegeWarning()function to one of that file and added it to one of them. And tests failed.I realized that they were identical. So, I added the function to
utils. Then, I realized that there wastest-utilsafter a comment. And movedsymlinkPrivilegeWarning()to that folder.But this made me think to merge those 2 duplicated files into one file in
test-utils.I want your opinion. If you say yes, I'll make a PR about this.
💻 Code Sample
None.
🌍 Your Environment
Unrelated.
The text was updated successfully, but these errors were encountered: