Fixed watcher stop CI test on Windows. #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
approved these changes
Feb 1, 2019
|
@devongovett could this be merged? |
DeMoorJasper
pushed a commit
that referenced
this pull request
Feb 3, 2019
#2605) * Ignore Kotlin tests and show messages when Java is not installed or configured. (#2603) * Skip symlink tests and show warning message when tests are run without admin privilege. (#2602) * Moved parcel-bundler/test/utils.js and integration-tests/test/utils.js into test-utils/src/utils.js. (#2604) * Fixed eslint errors. * Use the test to assert this.child.killed rather than checking time difference. (#2609) (#2612)
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 13, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 14, 2019
wbinnssmith
pushed a commit
that referenced
this pull request
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
watcher.stop()test failed on Windows 10. Details on #2609.🤔 What is changed?
In the previous test, it compared the time to check if stop() is called successfully.
After reading child process document and some nodejs code, it is a better solution to check
killedrather than using time differences.Because
this.child.killedis set to true whenkillorTerminateProcessfinished their job correctly.💻 Examples
N/A
🚨 Test instructions
When added a pull request, it failed.
✔️ PR Todo