-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows watcher CI test fails. #2609
Labels
Comments
3 tasks
sainthkh
added a commit
to sainthkh/parcel
that referenced
this issue
Feb 1, 2019
This was referenced Feb 1, 2019
devongovett
pushed a commit
that referenced
this issue
Feb 2, 2019
DeMoorJasper
pushed a commit
that referenced
this issue
Feb 3, 2019
#2605) * Ignore Kotlin tests and show messages when Java is not installed or configured. (#2603) * Skip symlink tests and show warning message when tests are run without admin privilege. (#2602) * Moved parcel-bundler/test/utils.js and integration-tests/test/utils.js into test-utils/src/utils.js. (#2604) * Fixed eslint errors. * Use the test to assert this.child.killed rather than checking time difference. (#2609) (#2612)
wbinnssmith
pushed a commit
that referenced
this issue
Mar 13, 2019
wbinnssmith
pushed a commit
that referenced
this issue
Mar 14, 2019
wbinnssmith
pushed a commit
that referenced
this issue
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 bug report
On Windows with Node 8+, CI watcher test, "Should be able to properly destroy the watcher", fails.
There is no problem with 6.
On local machine (Windows 10 Pro), it works correctly. It took about 14ms to finish.
🎛 Configuration (.babelrc, package.json, cli command)
N/A
🤔 Expected Behavior
It should take at least 1ms to finish the Watcher.stop() method. So, the test should pass when we check
😯 Current Behavior
But it took 0ms and caused an error.
Error message copied from this
💁 Possible Solution
According to the
subprocess.kill
doc, kill callssignal
function withSIGTERM
signal.The thing that I should research now is how this *nix function is implemented in Node 10 to understand why this happened.
🔦 Context
When contributing code, it can make new contributors confusing with failed tests.
💻 Code Sample
None.
🌍 Your Environment
It works fine in Windows 10 Pro.
The text was updated successfully, but these errors were encountered: