Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows watcher CI test fails. #2609

Closed
sainthkh opened this issue Jan 31, 2019 · 0 comments
Closed

Windows watcher CI test fails. #2609

sainthkh opened this issue Jan 31, 2019 · 0 comments

Comments

@sainthkh
Copy link
Contributor

🐛 bug report

On Windows with Node 8+, CI watcher test, "Should be able to properly destroy the watcher", fails.

There is no problem with 6.

On local machine (Windows 10 Pro), it works correctly. It took about 14ms to finish.

🎛 Configuration (.babelrc, package.json, cli command)

N/A

🤔 Expected Behavior

It should take at least 1ms to finish the Watcher.stop() method. So, the test should pass when we check

😯 Current Behavior

But it took 0ms and caused an error.

2019-01-31T21:17:04.7915888Z   1) Watcher
2019-01-31T21:17:04.7915937Z        Should be able to properly destroy the watcher:
2019-01-31T21:17:04.7915985Z 
2019-01-31T21:17:04.7916035Z       AssertionError [ERR_ASSERTION]: 1548969421444 != 1548969421444
2019-01-31T21:17:04.7916102Z       + expected - actual
2019-01-31T21:17:04.7916207Z 
2019-01-31T21:17:04.7916230Z 
2019-01-31T21:17:04.7916275Z       at Context.it (test\fswatcher.js:30:12)
2019-01-31T21:17:04.7916346Z       at process._tickCallback (internal/process/next_tick.js:68:7)

Error message copied from this

💁 Possible Solution

According to the subprocess.kill doc, kill calls signal function with SIGTERM signal.

The thing that I should research now is how this *nix function is implemented in Node 10 to understand why this happened.

🔦 Context

When contributing code, it can make new contributors confusing with failed tests.

💻 Code Sample

None.

🌍 Your Environment

Software Version(s)
Parcel 1.11.0
Node 10.15.0
npm/Yarn 1.12.3
Operating System Windows Server 2016

It works fine in Windows 10 Pro.

@sainthkh sainthkh changed the title Windows watcher CI. Windows watcher CI test fails. Jan 31, 2019
sainthkh added a commit to sainthkh/parcel that referenced this issue Feb 1, 2019
DeMoorJasper pushed a commit that referenced this issue Feb 3, 2019
#2605)

* Ignore Kotlin tests and show messages when Java is not installed or configured. (#2603)

* Skip symlink tests and show warning message when tests are run without admin privilege. (#2602)

* Moved parcel-bundler/test/utils.js and integration-tests/test/utils.js into test-utils/src/utils.js. (#2604)

* Fixed eslint errors.

* Use the test to assert this.child.killed rather than checking time difference. (#2609) (#2612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants