Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: golang.org/x/exp/slices usage is outdated #45976

Closed
ernado opened this issue Aug 10, 2023 · 1 comment · Fixed by #46433
Closed

parser: golang.org/x/exp/slices usage is outdated #45976

ernado opened this issue Aug 10, 2023 · 1 comment · Fixed by #46433
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. component/parser severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@ernado
Copy link

ernado commented Aug 10, 2023 

# github.com/pingcap/tidb/parser/charset
/go/pkg/mod/github.com/pingcap/tidb/[email protected]/charset/charset.go:94:28: type func(i *Charset, j *Charset) bool of func(i, j *Charset) bool {…} does not match inferred type func(a *Charset, b *Charset) int for func(a E, b E) int

The slices.SortFunc changed it's signature.
@ernado ernado added the type/bug The issue is confirmed as a bug. label Aug 10, 2023
@ernado ernado mentioned this issue Aug 10, 2023
Closed
2 tasks
@hawkingrei hawkingrei mentioned this issue Aug 26, 2023
Merged
12 tasks
@hawkingrei
Copy link
Member

@ernado After #46433 merging, TiDB doesn't use exp/slices.

@windard windard mentioned this issue Nov 23, 2023
Closed
@D3Hunter D3Hunter mentioned this issue Jun 4, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Jun 4, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Jun 4, 2024
Closed
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 4, 2024
@D3Hunter
*: upgrade x/exp/slices version (#53785)
607c846 
ref #45976
@D3Hunter D3Hunter mentioned this issue Oct 31, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added the affects-7.1 This bug affects the 7.1.x(LTS) versions. label Nov 4, 2024
ti-chi-bot bot pushed a commit that referenced this issue Nov 4, 2024
@D3Hunter
*: upgrade x/exp/slices version (#57046)
bc77c51 
ref #45976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. component/parser severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
4 participants
@ernado @hawkingrei @seiya-annie @ti-chi-bot