-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade x/exp/slices version #57046
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
41eae2f
to
b5fc331
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #57046 +/- ##
================================================
Coverage ? 73.4656%
================================================
Files ? 1212
Lines ? 380718
Branches ? 0
================================================
Hits ? 279697
Misses ? 83183
Partials ? 17838 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold for a while, to confirm that every thing tiflow needed are changed |
/unhold |
What problem does this PR solve?
Issue Number: ref #45976
Problem Summary:
What changed and how does it work?
in tiflow repo, we want to pick pingcap/tiflow#11700, but it upgrades
x/exp
which is in-compatible with tidb/parser.this PR is a manually pick of #53785
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.