Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some query execution stats was omitted when execution was interrupted #51660

Closed
crazycs520 opened this issue Mar 11, 2024 · 0 comments · Fixed by #51787
Closed

some query execution stats was omitted when execution was interrupted #51660

crazycs520 opened this issue Mar 11, 2024 · 0 comments · Fixed by #51787
Assignees
Labels
severity/minor sig/diagnosis SIG: Diagnosis type/bug The issue is confirmed as a bug.

Comments

@crazycs520
Copy link
Contributor

Bug Report

1. Minimal reproduce step (Required)

Execute query with max_execution_time, and make the query execution was interrupted, cause by maximum statement execution time exceeded.

Then the query slow info is following, the executor rpc stats was omitted!!!

image

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master: f2ae698

@crazycs520 crazycs520 added type/bug The issue is confirmed as a bug. severity/minor labels Mar 11, 2024
@crazycs520 crazycs520 self-assigned this Mar 11, 2024
@jebter jebter added the sig/diagnosis SIG: Diagnosis label Mar 12, 2024
ti-chi-bot bot pushed a commit that referenced this issue Mar 18, 2024
crazycs520 added a commit to crazycs520/tidb that referenced this issue May 16, 2024
cfzjywxk pushed a commit that referenced this issue May 21, 2024
* sessionctx: add sysvar to control exp feats of replica selector

Signed-off-by: zyguan <[email protected]>

* *: add rpc error stats and refine log (#52810)

Signed-off-by: crazycs520 <[email protected]>

* store: refine coprocessor error log (#52729)

Signed-off-by: crazycs520 <[email protected]>

* *: improve log about stale-read query (#52494)

Signed-off-by: crazycs520 <[email protected]>

* *: refine tikv/client-go log to print context information(such as conn id) as much as possible (#45559)

Signed-off-by: crazycs520 <[email protected]>

* add leader peer id log

Signed-off-by: crazycs520 <[email protected]>

* update log

Signed-off-by: crazycs520 <[email protected]>

* executor: fix issue that some query execution stats was omitted when execution was interrupted (#51787)

close #51660

Signed-off-by: crazycs520 <[email protected]>

* update go.mod

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: zyguan <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Co-authored-by: zyguan <[email protected]>
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this issue May 30, 2024
…#53335) (pingcap#96)

* *: add rpc error stats and refine log for diagnose (pingcap#53335)

* sessionctx: add sysvar to control exp feats of replica selector

Signed-off-by: zyguan <[email protected]>

* *: add rpc error stats and refine log (pingcap#52810)

Signed-off-by: crazycs520 <[email protected]>

* store: refine coprocessor error log (pingcap#52729)

Signed-off-by: crazycs520 <[email protected]>

* *: improve log about stale-read query (pingcap#52494)

Signed-off-by: crazycs520 <[email protected]>

* *: refine tikv/client-go log to print context information(such as conn id) as much as possible (pingcap#45559)

Signed-off-by: crazycs520 <[email protected]>

* add leader peer id log

Signed-off-by: crazycs520 <[email protected]>

* update log

Signed-off-by: crazycs520 <[email protected]>

* executor: fix issue that some query execution stats was omitted when execution was interrupted (pingcap#51787)

close pingcap#51660

Signed-off-by: crazycs520 <[email protected]>

* update go.mod

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: zyguan <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Co-authored-by: zyguan <[email protected]>

* Update go.sum

* Update go.mod

---------

Signed-off-by: zyguan <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Co-authored-by: crazycs <[email protected]>
Co-authored-by: zyguan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/diagnosis SIG: Diagnosis type/bug The issue is confirmed as a bug.
Projects
None yet
2 participants