-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store: refine coprocessor error log #52729
Conversation
Signed-off-by: crazycs520 <[email protected]>
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, MyonKeminta, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52729 +/- ##
================================================
+ Coverage 72.3230% 74.4120% +2.0890%
================================================
Files 1471 1473 +2
Lines 427219 427659 +440
================================================
+ Hits 308978 318230 +9252
+ Misses 98951 89596 -9355
- Partials 19290 19833 +543
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest-required |
@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: crazycs520 <[email protected]>
* sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <[email protected]> * *: add rpc error stats and refine log (#52810) Signed-off-by: crazycs520 <[email protected]> * store: refine coprocessor error log (#52729) Signed-off-by: crazycs520 <[email protected]> * *: improve log about stale-read query (#52494) Signed-off-by: crazycs520 <[email protected]> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (#45559) Signed-off-by: crazycs520 <[email protected]> * add leader peer id log Signed-off-by: crazycs520 <[email protected]> * update log Signed-off-by: crazycs520 <[email protected]> * executor: fix issue that some query execution stats was omitted when execution was interrupted (#51787) close #51660 Signed-off-by: crazycs520 <[email protected]> * update go.mod Signed-off-by: crazycs520 <[email protected]> --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: zyguan <[email protected]>
…#53335) (pingcap#96) * *: add rpc error stats and refine log for diagnose (pingcap#53335) * sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <[email protected]> * *: add rpc error stats and refine log (pingcap#52810) Signed-off-by: crazycs520 <[email protected]> * store: refine coprocessor error log (pingcap#52729) Signed-off-by: crazycs520 <[email protected]> * *: improve log about stale-read query (pingcap#52494) Signed-off-by: crazycs520 <[email protected]> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (pingcap#45559) Signed-off-by: crazycs520 <[email protected]> * add leader peer id log Signed-off-by: crazycs520 <[email protected]> * update log Signed-off-by: crazycs520 <[email protected]> * executor: fix issue that some query execution stats was omitted when execution was interrupted (pingcap#51787) close pingcap#51660 Signed-off-by: crazycs520 <[email protected]> * update go.mod Signed-off-by: crazycs520 <[email protected]> --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: zyguan <[email protected]> * Update go.sum * Update go.mod --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: zyguan <[email protected]>
What problem does this PR solve?
Issue Number: ref #52464
Problem Summary: refine log for diagnose.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.