executor: fix issue that some query execution stats was omitted when execution was interrupted #51787

crazycs520 · 2024-03-14T09:54:30Z

What problem does this PR solve?

Issue Number: close #51660

Problem Summary: fix issue that some query execution stats was omitted when execution was interrupted.

What changed and how does it work?

This PR:

Execute query with max_execution_time, and make the query execution was interrupted, cause by maximum statement execution time exceeded. Then the slow query info still have executor stats.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…was interrupted Signed-off-by: crazycs520 <[email protected]>

Signed-off-by: crazycs520 <[email protected]>

tiprow · 2024-03-14T09:54:46Z

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: crazycs520 <[email protected]>

codecov · 2024-03-14T10:36:33Z

Codecov Report

Merging #51787 (71883b2) into master (c95a54c) will decrease coverage by 15.7991%.
Report is 48 commits behind head on master.
The diff coverage is 87.2340%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #51787         +/-   ##
=================================================
- Coverage   70.7160%   54.9169%   -15.7991%     
=================================================
  Files          1476       1583        +107     
  Lines        437502     614366     +176864     
=================================================
+ Hits         309384     337391      +28007     
- Misses       108721     254685     +145964     
- Partials      19397      22290       +2893

Flag	Coverage Δ
integration	`36.8904% <78.7234%> (?)`
unit	`70.9877% <87.2340%> (+0.4560%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9957% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`51.4732% <ø> (+5.5695%)`	⬆️

crazycs520 · 2024-03-14T11:32:58Z

/test check-dev2

tiprow · 2024-03-14T11:33:19Z

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2024-03-15T05:25:45Z

[LGTM Timeline notifier]

Timeline:

2024-03-14 11:13:44.723444974 +0000 UTC m=+943251.745691363: ☑️ agreed by you06.
2024-03-15 05:25:44.805228422 +0000 UTC m=+1008771.827474809: ☑️ agreed by lcwangchao.

crazycs520 · 2024-03-15T06:03:16Z

/test fast_test_tiprow

ti-chi-bot · 2024-03-15T06:03:19Z

@crazycs520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-03-15T06:03:37Z

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crazycs520 · 2024-03-15T06:13:10Z

/retest-required

tiprow · 2024-03-15T06:13:31Z

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crazycs520 · 2024-03-15T06:18:06Z

/ok-to-test

crazycs520 · 2024-03-15T07:07:58Z

/retest

crazycs520 · 2024-03-18T07:42:42Z

@Benjamin2037 PTAL

pkg/distsql/select_result.go

Benjamin2037

LGTM

ti-chi-bot · 2024-03-18T08:30:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lcwangchao, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Benjamin2037,lcwangchao,you06]
~~pkg/distsql/OWNERS~~ [Benjamin2037]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

crazycs520 · 2024-03-18T08:32:52Z

/merge

ti-chi-bot · 2024-03-18T08:32:54Z

@crazycs520: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Rustin170506 · 2024-03-26T09:11:40Z

I think this PR introduced a panic:

[2024/03/19 09:52:29.783 +08:00] [ERROR] [analyze.go:520] ["analyze worker panicked"] [recover="runtime error: invalid memory address or nil pointer dereference"] [stack="github.com/pingcap/tidb/pkg/executor.(*AnalyzeExec).analyzeWorker.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/analyze.go:520\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:914\nruntime.panicmem\n\t/usr/local/go/src/runtime/panic.go:261\nruntime.sigpanic\n\t/usr/local/go/src/runtime/signal_unix.go:861\ngithub.com/pingcap/tidb/pkg/distsql.(*selectResult).Close\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/distsql/select_result.go:610\ngithub.com/pingcap/tidb/pkg/executor.closeAll\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/distsql.go:138\ngithub.com/pingcap/tidb/pkg/executor.(*AnalyzeIndexExec).buildStats.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/analyze_idx.go:102\ngithub.com/pingcap/tidb/pkg/executor.(*AnalyzeIndexExec).buildStats\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/analyze_idx.go:109\ngithub.com/pingcap/tidb/pkg/executor.analyzeIndexPushdown\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/analyze_idx.go:59\ngithub.com/pingcap/tidb/pkg/executor.(*AnalyzeExec).analyzeWorker\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/analyze.go:547\ngithub.com/pingcap/tidb/pkg/executor.(*AnalyzeExec).Next.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/analyze.go:119\ngithub.com/pingcap/tidb/pkg/util.(*WaitGroupPool).Run.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/util/wait_group_wrapper.go:213\ngithub.com/tiancaiamao/gp.worker\n\t/go/pkg/mod/github.com/tiancaiamao/[email protected]/gp.go:37"]

…execution was interrupted (pingcap#51787) close pingcap#51660 Signed-off-by: crazycs520 <[email protected]>

* sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <[email protected]> * *: add rpc error stats and refine log (#52810) Signed-off-by: crazycs520 <[email protected]> * store: refine coprocessor error log (#52729) Signed-off-by: crazycs520 <[email protected]> * *: improve log about stale-read query (#52494) Signed-off-by: crazycs520 <[email protected]> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (#45559) Signed-off-by: crazycs520 <[email protected]> * add leader peer id log Signed-off-by: crazycs520 <[email protected]> * update log Signed-off-by: crazycs520 <[email protected]> * executor: fix issue that some query execution stats was omitted when execution was interrupted (#51787) close #51660 Signed-off-by: crazycs520 <[email protected]> * update go.mod Signed-off-by: crazycs520 <[email protected]> --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: zyguan <[email protected]>

…#53335) (pingcap#96) * *: add rpc error stats and refine log for diagnose (pingcap#53335) * sessionctx: add sysvar to control exp feats of replica selector Signed-off-by: zyguan <[email protected]> * *: add rpc error stats and refine log (pingcap#52810) Signed-off-by: crazycs520 <[email protected]> * store: refine coprocessor error log (pingcap#52729) Signed-off-by: crazycs520 <[email protected]> * *: improve log about stale-read query (pingcap#52494) Signed-off-by: crazycs520 <[email protected]> * *: refine tikv/client-go log to print context information(such as conn id) as much as possible (pingcap#45559) Signed-off-by: crazycs520 <[email protected]> * add leader peer id log Signed-off-by: crazycs520 <[email protected]> * update log Signed-off-by: crazycs520 <[email protected]> * executor: fix issue that some query execution stats was omitted when execution was interrupted (pingcap#51787) close pingcap#51660 Signed-off-by: crazycs520 <[email protected]> * update go.mod Signed-off-by: crazycs520 <[email protected]> --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: zyguan <[email protected]> * Update go.sum * Update go.mod --------- Signed-off-by: zyguan <[email protected]> Signed-off-by: crazycs520 <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: zyguan <[email protected]>

crazycs520 added 2 commits March 14, 2024 16:56

fix issue that some query execution stats was omitted when execution …

de28a14

…was interrupted Signed-off-by: crazycs520 <[email protected]>

refine

fa859bb

Signed-off-by: crazycs520 <[email protected]>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2024

fix ci

71883b2

Signed-off-by: crazycs520 <[email protected]>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2024

you06 approved these changes Mar 14, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 14, 2024

lcwangchao approved these changes Mar 15, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 15, 2024

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 15, 2024

Benjamin2037 reviewed Mar 18, 2024

View reviewed changes

pkg/distsql/select_result.go Show resolved Hide resolved

Benjamin2037 approved these changes Mar 18, 2024

View reviewed changes

ti-chi-bot bot added the approved label Mar 18, 2024

ti-chi-bot bot merged commit 7056209 into pingcap:master Mar 18, 2024
23 checks passed

crazycs520 deleted the fix-stats-omit2 branch March 18, 2024 15:07

jiyfhust mentioned this pull request Mar 20, 2024

runtime error: invalid memory address or nil pointer dereference by merge unconsumedCopStats #51928

Closed

D3Hunter mentioned this pull request Mar 21, 2024

Panic in the TestVerifyChecksum #51951

Closed

Rustin170506 mentioned this pull request Mar 26, 2024

unclear error message for failed analyze jobs #52071

Closed

crazycs520 added a commit to crazycs520/tidb that referenced this pull request May 16, 2024

executor: fix issue that some query execution stats was omitted when …

9882f6a

…execution was interrupted (pingcap#51787) close pingcap#51660 Signed-off-by: crazycs520 <[email protected]>

crazycs520 mentioned this pull request May 21, 2024

*: add rpc error stats and refine log for diagnose #53335

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor: fix issue that some query execution stats was omitted when execution was interrupted #51787

executor: fix issue that some query execution stats was omitted when execution was interrupted #51787

crazycs520 commented Mar 14, 2024

tiprow bot commented Mar 14, 2024

codecov bot commented Mar 14, 2024 •

edited

Loading

crazycs520 commented Mar 14, 2024

tiprow bot commented Mar 14, 2024

ti-chi-bot bot commented Mar 15, 2024

crazycs520 commented Mar 15, 2024

ti-chi-bot bot commented Mar 15, 2024

tiprow bot commented Mar 15, 2024

crazycs520 commented Mar 15, 2024

tiprow bot commented Mar 15, 2024

crazycs520 commented Mar 15, 2024

crazycs520 commented Mar 15, 2024

crazycs520 commented Mar 18, 2024

Benjamin2037 left a comment

ti-chi-bot bot commented Mar 18, 2024

crazycs520 commented Mar 18, 2024

ti-chi-bot bot commented Mar 18, 2024

Rustin170506 commented Mar 26, 2024

executor: fix issue that some query execution stats was omitted when execution was interrupted #51787

executor: fix issue that some query execution stats was omitted when execution was interrupted #51787

Conversation

crazycs520 commented Mar 14, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Mar 14, 2024

codecov bot commented Mar 14, 2024 • edited Loading

Codecov Report

crazycs520 commented Mar 14, 2024

tiprow bot commented Mar 14, 2024

ti-chi-bot bot commented Mar 15, 2024

[LGTM Timeline notifier]

crazycs520 commented Mar 15, 2024

ti-chi-bot bot commented Mar 15, 2024

tiprow bot commented Mar 15, 2024

crazycs520 commented Mar 15, 2024

tiprow bot commented Mar 15, 2024

crazycs520 commented Mar 15, 2024

crazycs520 commented Mar 15, 2024

crazycs520 commented Mar 18, 2024

Benjamin2037 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Mar 18, 2024

crazycs520 commented Mar 18, 2024

ti-chi-bot bot commented Mar 18, 2024

Rustin170506 commented Mar 26, 2024

codecov bot commented Mar 14, 2024 •

edited

Loading