-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, parser, planner: admin Pause/Resume on DDL jobs #43081
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @dhysum! |
Hi @dhysum. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
4625224
to
d2fd020
Compare
/ok-to-test |
319f718
to
098831a
Compare
85e2051
to
554fa18
Compare
/retest |
554fa18
to
fabb2f3
Compare
846878e
to
38ed93b
Compare
38ed93b
to
e8fd4f9
Compare
e8fd4f9
to
a76f1c0
Compare
a76f1c0
to
40dee77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 40dee77
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Add Pause/Resume admin command in parser and planner
What problem does this PR solve?
Issue Number: close #18015 #40041
Related issue number: #39751 #43061
Problem Summary:
What is changed and how it works?
Add
admin pause ddl jobs 3,5;
a. the job should be in Running or Queueing state
b. change the state to be Pausing on command issued, in another PR
c. background work will pause the job once scheduled, in another PR
Add
admin resume ddl jobs 3,5;
a. the job should be paused
b. change the state to be Queueing on command issued, in another PR
c. background worker will continue the job, no need to change
Check List
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.