Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: background reorganization change for admin pause/resume ... #43297

Merged
merged 3 commits into from
May 10, 2023
Merged

ddl: background reorganization change for admin pause/resume ... #43297

merged 3 commits into from
May 10, 2023

Conversation

dhysum
Copy link
Contributor

@dhysum dhysum commented Apr 21, 2023 •
edited by Benjamin2037
Loading

What problem does this PR solve?
Issue Number: close #18015 #40041

Related issue number: #39751 #43061

Problem Summary: support admin pause ddl jobs 3,5; and admin resume ddl jobs 3,5;

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 21, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 21, 2023
@ti-chi-bot
Copy link
Member

Hi @dhysum. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Benjamin2037 Benjamin2037 mentioned this pull request Apr 21, 2023
Closed
5 tasks
@dhysum dhysum force-pushed the dev/job_pause_resume_full_changes branch 4 times, most recently from a7e66fd to f3ff992 Compare April 26, 2023 06:32
@zimulala
Copy link
Contributor

This PR seems that it's duplicated with #43171 end #43081. Could we close this PR?

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2023
@dhysum dhysum force-pushed the dev/job_pause_resume_full_changes branch 4 times, most recently from 73f6abb to c93207f Compare April 28, 2023 06:46
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@dhysum dhysum force-pushed the dev/job_pause_resume_full_changes branch 3 times, most recently from 0b73929 to 2efe0b3 Compare May 5, 2023 11:35
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 5, 2023
@dhysum dhysum force-pushed the dev/job_pause_resume_full_changes branch from 2efe0b3 to 5ee7fd5 Compare May 5, 2023 11:39
Benjamin2037
Benjamin2037 reviewed May 6, 2023
View reviewed changes
ddl/ddl_worker.go Outdated Show resolved Hide resolved
Benjamin2037
Benjamin2037 reviewed May 6, 2023
View reviewed changes
ddl/ddl_worker.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed May 6, 2023
View reviewed changes
ddl/reorg.go Show resolved Hide resolved
@dhysum dhysum force-pushed the dev/job_pause_resume_full_changes branch 2 times, most recently from 39cbeac to 57b957f Compare May 8, 2023 02:52
@dhysum
Copy link
Contributor Author

dhysum commented May 9, 2023 •
edited
Loading

Please add this test(#43171 (comment)) here ？

OK. There should be such cases on the resume action after paused. Such cases has been done manually, and will add it in another PR later on.

@dhysum dhysum force-pushed the dev/job_pause_resume_full_changes branch from 57b957f to 30e9dee Compare May 9, 2023 15:26
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023
@Benjamin2037
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 30e9dee

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2023
@zimulala
Copy link
Contributor

/merge

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2023
@wuhuizuo
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 10, 2023
@dhysum
Copy link
Contributor Author

dhysum commented May 10, 2023

/retest

1 similar comment
@dhysum
Copy link
Contributor Author

dhysum commented May 10, 2023

/retest

@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4f35e97

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit 5c31e16 into pingcap:master May 10, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 10, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43680.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 10, 2023
@dhysum @ti-chi-bot
This is an automated cherry-pick of pingcap#43297
e5ec42b 
Signed-off-by: ti-chi-bot <[email protected]>
@dhysum dhysum mentioned this pull request May 10, 2023
Merged
12 tasks
dhysum added a commit to dhysum/tidb that referenced this pull request May 11, 2023
@dhysum
ddl: background reorganization change for admin pause/resume ... (p…
cc58f85 
…ingcap#43297)

close pingcap#18015, ref pingcap#40041
@tangenta tangenta mentioned this pull request May 29, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@tangenta tangenta tangenta approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pause add an index(write reorganization) and set a time window to resume
7 participants
@dhysum @ti-chi-bot @zimulala @Benjamin2037 @hawkingrei @wuhuizuo @tangenta