Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/design: add a proposal for pausing user DDL when upgrading DDL #43061

Merged
merged 7 commits into from
Apr 28, 2023
Merged

docs/design: add a proposal for pausing user DDL when upgrading DDL #43061

merged 7 commits into from
Apr 28, 2023

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #43060

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2023
@zimulala zimulala added component/docs and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2023
@dhysum dhysum mentioned this pull request Apr 15, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2023
@zimulala
Copy link
Contributor Author

PTAL @tangenta @Benjamin2037

This was referenced Apr 18, 2023
Merged
Merged
@zimulala
Copy link
Contributor Author

PTAL @tangenta

Benjamin2037
Benjamin2037 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2023
@zimulala
Copy link
Contributor Author

PTAL @tangenta

@dhysum dhysum mentioned this pull request Apr 21, 2023
Merged
12 tasks
@zimulala
Copy link
Contributor Author

PTAL @tangenta

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2023
@zimulala zimulala force-pushed the zimuxia/pause-design branch from 26d1033 to 1021098 Compare April 28, 2023 03:23
@zimulala zimulala force-pushed the zimuxia/pause-design branch from 1021098 to 208ee5b Compare April 28, 2023 03:35
@zimulala
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 208ee5b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 33056ef into pingcap:master Apr 28, 2023
@zimulala zimulala deleted the zimuxia/pause-design branch April 28, 2023 05:11
This was referenced May 4, 2023
Closed
Closed
This was referenced May 10, 2023
Closed
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request May 10, 2023
Closed
12 tasks
@dhysum dhysum mentioned this pull request Jun 12, 2023
Merged
16 tasks
@ran-huang ran-huang mentioned this pull request Jun 15, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
component/docs release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pause user DDL when upgrading TiDB design
4 participants
@zimulala @ti-chi-bot @Benjamin2037 @tangenta