Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify tiflash default config #3414

Merged
merged 12 commits into from
Nov 18, 2021
Merged

modify tiflash default config #3414

merged 12 commits into from
Nov 18, 2021

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Nov 9, 2021 •
edited
Loading

What problem does this PR solve?

#3412

What is changed and how it works?

Proposal: https://pingcap.feishu.cn/sheets/shtcnaMkj4g1USPo1TLEv3nRVLh

What's Changed: Modify TiFlash default configuration value.

Related changes

pingcap/tidb-engine-ext#36

Check List

Tests

  • Unit test
  • Integration test

Release note 

Enhance default configurations of TiFlash.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2021
@hehechen hehechen self-assigned this Nov 9, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2021
@hehechen hehechen requested a review from JaySon-Huang November 9, 2021 09:43
jiaqizho
jiaqizho reviewed Nov 9, 2021
View reviewed changes
dbms/src/Core/Defines.h Outdated Show resolved Hide resolved
dbms/src/Server/Server.cpp Outdated Show resolved Hide resolved
libs/libdaemon/src/BaseDaemon.cpp Show resolved Hide resolved
@JaySon-Huang
Copy link
Contributor

You should file a PR to update the default value in https://github.com/pingcap/tidb-engine-ext first

@JaySon-Huang
Copy link
Contributor

/run-integration-tests

@JaySon-Huang
Copy link
Contributor

/run-unit-test

@hehechen hehechen mentioned this pull request Nov 10, 2021
Merged
@hehechen
Copy link
Contributor Author

You should file a PR to update the default value in https://github.com/pingcap/tidb-engine-ext first

done

JaySon-Huang
JaySon-Huang reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the configuration in /etc/config-template.toml aligned with https://pingcap.feishu.cn/sheets/shtcnaMkj4g1USPo1TLEv3nRVLh

libs/libdaemon/src/BaseDaemon.cpp Show resolved Hide resolved
dbms/src/Server/HTTPHandler.cpp Show resolved Hide resolved
JaySon-Huang
JaySon-Huang approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.
@flowbehappy Please take another look

dbms/src/Server/MetricsPrometheus.cpp Outdated Show resolved Hide resolved
dbms/src/Core/Defines.h
Comment on lines +91 to +98
#define DEFAULT_MARK_CACHE_SIZE (5ULL * 1024 * 1024 * 1024)

#define DEFAULT_METRICS_PORT 8234

#define DEFAULT_PROXY_ADDR "127.0.0.1:20170"

#define DEFAULT_HTTP_PORT 8123

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can define these constants near where we use them instead of in the Defines.h? If we change them one day, it would make a lot of files need to be re-compiled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can define these constants near where we use them instead of in the Defines.h? If we change them one day, it would make a lot of files need to be re-compiled.

I think it’s better to put the define of the default configuration together, just like the other default configurations in Defines.h.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
@hehechen hehechen requested a review from flowbehappy November 18, 2021 06:48
flowbehappy
flowbehappy approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hehechen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72c91e5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 18, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/107/cobertura/

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 18, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/109/cobertura/

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 18, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/111/cobertura/

@ti-chi-bot ti-chi-bot merged commit addb001 into pingcap:master Nov 18, 2021
@hehechen hehechen mentioned this pull request Nov 23, 2021
Closed
This was referenced Dec 14, 2021
Closed
Merged
Merged
@JaySon-Huang JaySon-Huang mentioned this pull request Jan 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaqizho jiaqizho jiaqizho left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees

@hehechen hehechen

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hehechen @ti-chi-bot @JaySon-Huang @sre-bot @flowbehappy @jiaqizho