Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from IQSS:develop #643

Open
wants to merge 2,654 commits into
base: develop
Choose a base branch
from
Open

[pull] develop from IQSS:develop #643

wants to merge 2,654 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Jul 9, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jul 9, 2024
@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build #709

Details

  • 351 of 1874 (18.73%) changed or added relevant lines in 90 files are covered.
  • 36 unchanged lines in 20 files lost coverage.
  • Overall coverage increased (+0.08%) to 20.71%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/harvard/iq/dataverse/Dataset.java 4 5 80.0%
src/main/java/edu/harvard/iq/dataverse/EjbDataverseEngine.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/GuestbookResponsesPage.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/ManageGuestbooksPage.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/api/AbstractApiBean.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/api/imports/ImportGenericServiceBean.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/authorization/providers/builtin/PasswordEncryption.java 1 2 50.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DuraCloudSubmitToArchiveCommand.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GoogleCloudSubmitToArchiveCommand.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/S3SubmitToArchiveCommand.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/harvard/iq/dataverse/export/dublincore/DublinCoreExportUtil.java 1 75.7%
src/main/java/edu/harvard/iq/dataverse/DatasetPage.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/XmlMetadataTemplate.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/api/errorhandlers/WebApplicationExceptionHandler.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractCreateDatasetCommand.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/CreateDataverseCommand.java 1 70.59%
src/main/java/edu/harvard/iq/dataverse/api/SavedSearches.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/DatasetVersionServiceBean.java 1 2.54%
src/main/java/edu/harvard/iq/dataverse/DatasetFieldServiceBean.java 1 15.34%
src/main/java/edu/harvard/iq/dataverse/DatasetServiceBean.java 1 1.83%
Totals Coverage Status
Change from base Build #684: 0.08%
Covered Lines: 17601
Relevant Lines: 84988

💛 - Coveralls

landreev and others added 28 commits February 18, 2025 11:30
explain how to customize root collection in "running in Docker" tutorial
Bumps [appleboy/ssh-action](https://github.com/appleboy/ssh-action) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/appleboy/ssh-action/releases)
- [Changelog](https://github.com/appleboy/ssh-action/blob/master/.goreleaser.yaml)
- [Commits](appleboy/ssh-action@v1.2.0...v1.2.1)

---
updated-dependencies:
- dependency-name: appleboy/ssh-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ructor

- Modified constructor to require displayOnCreate parameter
- Updated all constructor calls to pass the correct displayOnCreate value
…ackoff_page_refresh

IQSS/11264 - Add pseudo-exponential backoff to dataset page refresh
Fix sorting of dataset drafts and minor versions when sorting by "newest first"
qqmyers and others added 30 commits March 6, 2025 13:56
…g-state-db-table

MDC Adding server to processing state table to allow the processing script to run on multiple servers
…e_enhancements

update etalab license to use the new JSON format
document behavior of Preview tab with regard to default license
…ID_1

ORCID: Support authenticated ORCIDs in account profile
…ayara6.2024.12

Upgrade to Payara 6 2025.2
Globus support: download optimizations
It is not necessary to use 4096 bit, as the error was about the wrong common name in the cert.

Detailed explanation:
Before, the cert presented to Jakarta Mail neither contained a commonName=localhost nor subjectAltName=localhost.
This worked before with Payara 6.2024.6 because Eclipse Angus Mail 1.0.0 was still in use (see list of managed dependencies on the 6.2024.6 BOM).
Certificate host identity check was introduced as default=on with Eclipse Angus Mail 1.1.0 (see their release notes).
Now that Payara 6.2025.2 is in use on develop, we upgraded to Eclipse Angus Mail 2.3.0, making the error appear.
Including an openssl.conf makes it much easier and less error prone to generate the certs.
Rewriting the necessary shell command steps in the test comment to document the process.
Without the explicit addition of which port to use for the HTTP based waiting strategy, someone may end up at random with the SMTP port being picked.

This will obviously fail and result in aborted tests, making results flaky. Pinning the port down should prevent this for good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.