Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review old "needs backport" PRs #9384

Open
The-Compiler opened this issue Dec 7, 2021 · 1 comment
Open

Review old "needs backport" PRs #9384

The-Compiler opened this issue Dec 7, 2021 · 1 comment
Labels
type: infrastructure improvement to development/releases/CI structure

Comments

@The-Compiler
Copy link
Member

Looks like we have 35 old PRs with a "needs backport" label:

https://github.com/pytest-dev/pytest/pulls?q=is%3Apr+is%3Aclosed+label%3A%22needs+backport%22

Can we remove that, so we can use the label as a kind of "todo list" in the future still? What about the "backported" label, is that needed really?
@The-Compiler The-Compiler changed the title Review old "needs backport" PRs. Review old "needs backport" PRs Dec 7, 2021
@nicoddemus
Copy link
Member

Can we remove that, so we can use the label as a kind of "todo list" in the future still?

Sure, we probably just forgot to remove them after backporting.

What about the "backported" label, is that needed really?

It serves as a marker that a PR was actually backported; just removing the needs backport label leaves the situation ambiguous, because we don't know if a PR has been backported or we forgot to do it entirely.

@Zac-HD Zac-HD added the type: infrastructure improvement to development/releases/CI structure label Jan 7, 2022
webknjaz added a commit to webknjaz/pytest that referenced this issue Jun 18, 2024
@webknjaz
💅 Add a config for the Patchback GitHub App
711d37a 
This patch prepares the project's backporting process to start being
handled by the Patchback GitHub App [[1]].

Ref pytest-dev#9384
Resolves pytest-dev#9385
Resolves pytest-dev#9553
Resolves pytest-dev#9554
Resolves pytest-dev#9555

[1]: https://github.com/apps/patchback
@webknjaz webknjaz mentioned this issue Jun 18, 2024
Merged
nicoddemus pushed a commit that referenced this issue Jun 19, 2024
@webknjaz
💅 Add a config for the Patchback GitHub App (#12475)
d7b4010 
This patch prepares the project's backporting process to start being
handled by the Patchback GitHub App [[1]].

Ref #9384
Resolves #9385
Resolves #9553
Resolves #9554
Resolves #9555

[1]: https://github.com/apps/patchback
patchback bot pushed a commit that referenced this issue Jun 19, 2024
@webknjaz @patchback
💅 Add a config for the Patchback GitHub App (#12475)
fdc5375 
This patch prepares the project's backporting process to start being
handled by the Patchback GitHub App [[1]].

Ref #9384
Resolves #9385
Resolves #9553
Resolves #9554
Resolves #9555

[1]: https://github.com/apps/patchback

(cherry picked from commit d7b4010)
@patchback patchback bot mentioned this issue Jun 19, 2024
Merged
Glyphack pushed a commit to Glyphack/pytest that referenced this issue Jun 20, 2024
@webknjaz @Glyphack
💅 Add a config for the Patchback GitHub App (pytest-dev#12475)
2506e59 
This patch prepares the project's backporting process to start being
handled by the Patchback GitHub App [[1]].

Ref pytest-dev#9384
Resolves pytest-dev#9385
Resolves pytest-dev#9553
Resolves pytest-dev#9554
Resolves pytest-dev#9555

[1]: https://github.com/apps/patchback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@The-Compiler @nicoddemus @Zac-HD