-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport workflow: Add some feedback comments #9555
Comments
the back-port pr should auto-link by referring the origin pr maybe we can use a label as indicator like "backport-failed", and taking the label off and/or switching it to backport needed again could re-trigger a backport but that may bee a but pushing it on the mechanics |
I think transient backporting failures will be very rare. The most common reason a backport will fail is that there are conflicts, and at that point, a human will need to intervene. Still, deleting the branch and applying the label again will already trigger a new backport PR anyways. |
FYI I have a GitHub App for backporting @ https://github.com/apps/patchback. Here's the comments I came up with, for example:
(config: https://github.com/ansible-collections/community.general/blob/main/.github/patchback.yml) That's in case you'd want to borrow ideas or just use it — it's been online for quite a while now: https://github.com/ansible-collections/community.general/pulls?q=author%3Aapp%2Fpatchback. P.S. I like the labeling idea. My bot doesn't do it but I should probably implement that :) I think it's a good way for providing a discovery mechanism for PRs with failed backports. |
This patch prepares the project's backporting process to start being handled by the Patchback GitHub App [[1]]. Ref pytest-dev#9384 Resolves pytest-dev#9385 Resolves pytest-dev#9553 Resolves pytest-dev#9554 Resolves pytest-dev#9555 [1]: https://github.com/apps/patchback
This patch prepares the project's backporting process to start being handled by the Patchback GitHub App [[1]]. Ref pytest-dev#9384 Resolves pytest-dev#9385 Resolves pytest-dev#9553 Resolves pytest-dev#9554 Resolves pytest-dev#9555 [1]: https://github.com/apps/patchback
It would be good to get some (automated) feedback for the backport workflow. The bot could e.g. add a comment with a link to the backported PR if successful (and also take care of adding the "backported" label maybe?). Perhaps more importantly, if not successful, it should add a comment asking for a manual backport.
Right now, it's kind of "fire and forget", and if we don't carefully double-check, we risk accidentally forgetting about backports which should have been done.
The text was updated successfully, but these errors were encountered: