-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write script / GitHub Action for backporting #9385
Comments
Definitely! Just to comment that there's https://github.com/peter-evans/create-pull-request to create the actual PR. |
We probably can write everything in GitHub actions, without needing an auxiliary script. For example we can trigger a workflow when a PR is merged:
I have seen other projects have specific labels, say |
Agreed we can do it directly via Actions - but we already have scripts for other things we run there (e.g. preparing release PRs), and it also makes it easier to test things if we can run them independently. As for the label, I suppose we could just use the newest release branch - it's quite rare that we want to backport to an even older release. FWIW I use the peter-evans/create-pull-request action for qutebrowser though, quite happy with it! |
No problem. I'm not 100% convinced in this case TBH, feels like the "commands" to execute is just a single git command, and the tricky part is deciding when to trigger it, which seems easy to do directly with GitHub actions rather than implementing in a custom script which needs to call the API. But I'm not against using a custom script if whoever implements this prefers that way of course. 😁
Indeed, that's simple if we decide to use a custom script. |
👍 👍 👍 on this.
We use it for the periodic plugin list updates, but for some reason it has a problem where the tests don't trigger for the PRs it creates, I don't remember why. |
It needs to be triggered by a Private Access Token or a GitHub bot unfortunately (there's more information on the docs for that action IIRC). |
We mostly have done this, but @webknjaz mentioned he has a ready GitHub Action for this that solves some of the problems we have, so that might be worth exploring. |
I have an app, not an action. But yeah, let's explore that while we're all gathered in the same space :) |
This patch prepares the project's backporting process to start being handled by the Patchback GitHub App [[1]]. Ref pytest-dev#9384 Resolves pytest-dev#9385 Resolves pytest-dev#9553 Resolves pytest-dev#9554 Resolves pytest-dev#9555 [1]: https://github.com/apps/patchback
This patch prepares the project's backporting process to start being handled by the Patchback GitHub App [[1]]. Ref pytest-dev#9384 Resolves pytest-dev#9385 Resolves pytest-dev#9553 Resolves pytest-dev#9554 Resolves pytest-dev#9555 [1]: https://github.com/apps/patchback
There is a lot of manual work involved when backporting a PR to a release branch. Ideally, that would only be required if there are conflicts to be solved.
Would be cool to have a script to prepare a backport PR. Then, as a next step, that could be integrated into GitHub Actions so that the "needs backport" label automatically causes a bot to backport the PR to the newest maintenance branch (either when a closed PR is labelled, or when a labelled PR is merged).
Maybe something suitable exists already, I can't imagine us being the only project who needs something like that. I know the Qt Company has something very similar (after I suggested it to them, though I didn't implement it). Theirs is based on their own CI and Gerrit, though.
The text was updated successfully, but these errors were encountered: