Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority for partially downloaded multi-file torrents. #10994

Closed
Achaean opened this issue Jul 29, 2019 · 11 comments · Fixed by #16546
Closed

Priority for partially downloaded multi-file torrents. #10994

Achaean opened this issue Jul 29, 2019 · 11 comments · Fixed by #16546
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug GUI GUI-related issues/changes WebUI WebUI-related issues/changes

Comments

@Achaean
Copy link

Achaean commented Jul 29, 2019

Hi! :)

Lets say a torrent has 10 files, so I can leave 1 file to normal priority and set the rest 9 -> "Do not download".
After completing the torrent and testing the file, I decided to download the rest 9 files as well.
I can't see the priority setting any more! I can choose them so I can download them, but I don't have any control over their download priority.

I think, it would be nice to have a priority entry available on right-click (as you have at new torrents).

qBitt last stable version (4.1.6).

@WolfganP
Copy link

@Achaean does it happen in the QtUI or the WebUI. If the latter, I'm suffering the same issue as reported at #10153 (comment) but will retest once that PR is merged with master (there seems to be ongoing activity in that direction).

One workaround that worked for me is to trigger a files recheck, and while in progress, try to modify files priorities as needed (the selectors are temporarily available).

@Achaean
Copy link
Author

Achaean commented Jul 29, 2019

THANKS WolfganP!!! :-)
And...SORRY for not mentioning it! :-(
Normal interface. I didn't try the WebUI.

V.4.1.6 x64, Qt v.5.7.1, Libtorrent v.1.1.13.0, Boost v.1.62.0, compiled locally, on Devuan ASCII (stable) x64 KDE (based on Debian oldstable by now).

@WolfganP
Copy link

WolfganP commented Jul 30, 2019

@Achaean your my mirror world clone then :-) ... I use exclusively the WebUI and not even build the QtUI (nox user).

If we both suffer the issue then it seems is not a matter of the interface but the core enabling logic. Weird thing is that nothing appears in the logs, let's wait for troubleshooting instructions from devs.
I suggest you to edit the title as it's not a wishlist item but an actual issue.

@Achaean Achaean changed the title Priority for partially downloaded multi-file torrents [Wishlist]. Priority for partially downloaded multi-file torrents. Jul 30, 2019
@Achaean
Copy link
Author

Achaean commented Jul 30, 2019

OK! : -)

@Arathen
Copy link

Arathen commented Aug 6, 2019

I can confirm im also seeing this problem in the WebUI now that #10153 has been merged. Im running master @ c65c40a .

Solid workaround from @WolfganP tho. Priority can be changed while a recheck is in progress, but not at other times. Something @Piccirello should probably be made aware of.

@Piccirello
Copy link
Member

In my testing, once the torrent is complete all Download Priority select fields will be greyed out. If I re-check an ignored file's checkbox, the Download Priority field will then become available again (after the server responds, which may take a few seconds). Is this different than what other people are seeing?

@Arathen
Copy link

Arathen commented Aug 6, 2019

I think you're correct. Thats also what im seeing. The key is waiting for the server to respond, which I dont think I was doing in my previous test. I've checked it with a couple of different multi's just now, and it seems to work the way you describe.

Can somebody else confirm?

@WolfganP
Copy link

WolfganP commented Aug 6, 2019

I'm seeing the same behavior after building on latest master with #10153 merged.
There's a weird interaction between the individual file's checkboxes and the "Download priority" being greyed out.

Anyways, I think disabled Download priorities is the not proper behavior: they should be enabled for changes at any time so the user has control on which files to download and in which priority (at most being temporarily disabled on certain offline file operations like checking or moving files)

BTW, what's the purpose of the items checkboxes now that there's the ability to select multiple files and change priorities in bulk via the right click menu?

@Piccirello
Copy link
Member

Piccirello commented Aug 12, 2019

There's a weird interaction between the individual file's checkboxes and the "Download priority" being greyed out.

You're right- I think I'll change it so that it's only greyed out on completed files (since you can't change the priority of a completed file).

BTW, what's the purpose of the items checkboxes now that there's the ability to select multiple files and change priorities in bulk via the right click menu?

Honest answer- it's what people are used to. I haven't given any thought to if we should remove it.

@FranciscoPombal FranciscoPombal added Confirmed bug An issue confirmed by project team to be considered as a bug GUI GUI-related issues/changes WebUI WebUI-related issues/changes labels Feb 18, 2020
@SteveS8
Copy link

SteveS8 commented Nov 25, 2020

This still an issue. When a torrent has finished downloading you can't set the priority anymore. And that includes selecting multiple files and changing them from "to not download" to normal. So you have to click on each checkbox individually. Or get one file started so "revive" the torrent. And then suddenly the priority setting is there again for all files. Including ones that are are already finished.

The latter is fine by the way. One may think that you don't need to set the priority for finished files. But I sometimes abuse that setting to mark that I already watched a file.

@a-sum-duma
Copy link
Contributor

#8673 is a subset of this issue (#8673 is about right-click menu in QT GUI while this issue is about changing download priority in general in both QT and WEB UI).

a-sum-duma added a commit to a-sum-duma/qBittorrent that referenced this issue Nov 6, 2021
even if a torrent is in "seeding" state. Fixes qbittorrent#10994 qbittorrent#8673
Chocobo1 pushed a commit that referenced this issue Mar 1, 2022
Currently you can't directly change the priority of a partially completed multi file torrent. You'll have to start downloading those files and then change their priority.

Closes #10994.
Closes #8673.
PR #16546.
sledgehammer999 pushed a commit to sledgehammer999/qBittorrent that referenced this issue Mar 20, 2022
Currently you can't directly change the priority of a partially completed multi file torrent. You'll have to start downloading those files and then change their priority.

Closes qbittorrent#10994.
Closes qbittorrent#8673.
PR qbittorrent#16546.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed bug An issue confirmed by project team to be considered as a bug GUI GUI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants