-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priority for partially downloaded multi-file torrents. #10994
Comments
@Achaean does it happen in the QtUI or the WebUI. If the latter, I'm suffering the same issue as reported at #10153 (comment) but will retest once that PR is merged with master (there seems to be ongoing activity in that direction). One workaround that worked for me is to trigger a files recheck, and while in progress, try to modify files priorities as needed (the selectors are temporarily available). |
THANKS WolfganP!!! :-) V.4.1.6 x64, Qt v.5.7.1, Libtorrent v.1.1.13.0, Boost v.1.62.0, compiled locally, on Devuan ASCII (stable) x64 KDE (based on Debian oldstable by now). |
@Achaean your my mirror world clone then :-) ... I use exclusively the WebUI and not even build the QtUI (nox user). If we both suffer the issue then it seems is not a matter of the interface but the core enabling logic. Weird thing is that nothing appears in the logs, let's wait for troubleshooting instructions from devs. |
OK! : -) |
I can confirm im also seeing this problem in the WebUI now that #10153 has been merged. Im running master @ c65c40a . Solid workaround from @WolfganP tho. Priority can be changed while a recheck is in progress, but not at other times. Something @Piccirello should probably be made aware of. |
In my testing, once the torrent is complete all Download Priority select fields will be greyed out. If I re-check an ignored file's checkbox, the Download Priority field will then become available again (after the server responds, which may take a few seconds). Is this different than what other people are seeing? |
I think you're correct. Thats also what im seeing. The key is waiting for the server to respond, which I dont think I was doing in my previous test. I've checked it with a couple of different multi's just now, and it seems to work the way you describe. Can somebody else confirm? |
I'm seeing the same behavior after building on latest master with #10153 merged. Anyways, I think disabled Download priorities is the not proper behavior: they should be enabled for changes at any time so the user has control on which files to download and in which priority (at most being temporarily disabled on certain offline file operations like checking or moving files) BTW, what's the purpose of the items checkboxes now that there's the ability to select multiple files and change priorities in bulk via the right click menu? |
You're right- I think I'll change it so that it's only greyed out on completed files (since you can't change the priority of a completed file).
Honest answer- it's what people are used to. I haven't given any thought to if we should remove it. |
This still an issue. When a torrent has finished downloading you can't set the priority anymore. And that includes selecting multiple files and changing them from "to not download" to normal. So you have to click on each checkbox individually. Or get one file started so "revive" the torrent. And then suddenly the priority setting is there again for all files. Including ones that are are already finished. The latter is fine by the way. One may think that you don't need to set the priority for finished files. But I sometimes abuse that setting to mark that I already watched a file. |
even if a torrent is in "seeding" state. Fixes qbittorrent#10994 qbittorrent#8673
Currently you can't directly change the priority of a partially completed multi file torrent. You'll have to start downloading those files and then change their priority. Closes qbittorrent#10994. Closes qbittorrent#8673. PR qbittorrent#16546.
Hi! :)
Lets say a torrent has 10 files, so I can leave 1 file to normal priority and set the rest 9 -> "Do not download".
After completing the torrent and testing the file, I decided to download the rest 9 files as well.
I can't see the priority setting any more! I can choose them so I can download them, but I don't have any control over their download priority.
I think, it would be nice to have a priority entry available on right-click (as you have at new torrents).
qBitt last stable version (4.1.6).
The text was updated successfully, but these errors were encountered: