Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disabled Oracle tests #740

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Enable disabled Oracle tests #740

merged 1 commit into from
Jun 30, 2022

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented Jun 30, 2022

Summary

Resolved upstream issues:

Follow-up to #563.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jsmrcka jsmrcka requested a review from michalvavrik June 30, 2022 13:55
@jsmrcka jsmrcka self-assigned this Jun 30, 2022
michalvavrik
michalvavrik approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that databaseOracleConstraintFailure is the only one with path /* (because it made me thinking why it differs to others and look to code/ reference guide), but the path wasn't changed in this PR, so it's okay.

LGTM

@michalvavrik michalvavrik merged commit 5fafe4d into quarkus-qe:main Jun 30, 2022
@jsmrcka jsmrcka deleted the fix/oracle-diabled-tests branch July 1, 2022 07:48
@jsmrcka jsmrcka mentioned this pull request Jul 1, 2022
Merged
8 tasks
@jsmrcka
Copy link
Contributor Author

jsmrcka commented Jul 1, 2022

It's strange that databaseOracleConstraintFailure is the only one with path /* (because it made me thinking why it differs to others and look to code/ reference guide), but the path wasn't changed in this PR, so it's okay.

LGTM

Let's fix that, in order to avoid future confusion: #741.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees

@jsmrcka jsmrcka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsmrcka @michalvavrik