Reactive Oracle client does not provide an Oracle-specific exception

[jsmrcka]

Describe the bug

Unlike other reactive DB clients (reactive-pg-client, reactive-mysql-client, reactive-mssql-client, reactive-db2-client), Reactive Oracle client (reactive-oracle-client) does not provide an Oracle-specific exception, something like OracleException, which would be thrown in case of a failure.

    @Inject
    OraclePool oraclePool;

    ...

    private Uni<String> getError() {
        return oraclePool.query("BAD QUERY")
                .execute()
                .onItem().transform(RowSet::iterator)
                .onItem().transform(iterator -> "dummy string")
                .onFailure(RuntimeException.class).recoverWithItem(e -> e.getClass().getName());
    }

Instead, it uses generic io.vertx.core.VertxException.

This makes it harder to e.g. handle DB-specific exceptions.

Instead of:

public class FailureHandler {
    @Route(path = "/*", type = Route.HandlerType.FAILURE, produces = "application/json")
    void databaseOracleConstraintFailure(OracleException e, HttpServerResponse response) {
        response.setStatusCode(400).end(Json.encode(new JsonObject().put("msg", e.getMessage())));
    }
}

you have to do:

public class FailureHandler {
    @Route(path = "/*", type = Route.HandlerType.FAILURE, produces = "application/json")
    void databaseOracleConstraintFailure(VertxException e, HttpServerResponse response) {
        if (e.getMessage().contains("Error Msg = ORA")) {
            response.setStatusCode(400).end(Json.encode(new JsonObject().put("msg", e.getMessage())));
        }
    }
}

Expected behavior

An Oracle-specific exception is thrown in case of a failure.

Actual behavior

Generic io.vertx.core.VertxException is thrown.

How to Reproduce?

reactive-oracle-client-reproducer.zip

unzip reactive-oracle-client-reproducer.zip
cd ./reactive-oracle-client-reproducer
./mvnw clean test

Output of uname -a or ver

Linux ... 5.16.12-200.fc35.x86_64

Output of java -version

openjdk version "11.0.14" 2022-01-18 OpenJDK Runtime Environment Temurin-11.0.14+9 (build 11.0.14+9) OpenJDK 64-Bit Server VM Temurin-11.0.14+9 (build 11.0.14+9, mixed mode)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.7.4.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.4

Additional information

No response

[geoand]

cc @tsegismont

[tsegismont]

@jsmrcka can you please file an issue on https://github.com/eclipse-vertx/vertx-sql-client ? Thanks

[jsmrcka]

Fixed in eclipse-vertx/vertx-sql-client#1160.
Brought into Quarkus in #24316 (0dbc247).
Verified on 2.10.0.Final.