Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a new user, I can enter my first and last name #191

Closed
17 tasks
lfrohlich opened this issue Aug 26, 2020 · 1 comment · Fixed by #247 or #256
Closed
17 tasks

As a new user, I can enter my first and last name #191

lfrohlich opened this issue Aug 26, 2020 · 1 comment · Fixed by #247 or #256
Assignees
Labels

Comments

@lfrohlich
Copy link
Collaborator

lfrohlich commented Aug 26, 2020

Description:
After they've created login.gov user account, users will be prompted to provide their first and last name. This will not include adding drop to search or select STT.

Next: #229

Excluded

  1. Name/text field validation
  2. Select or search combo box.
  3. Form submission and form validation.

AC:

Tasks:

Frontend

  • Form with first and last name but button will not lead to anything (dummy)
  • Code documentation and annotation of why system is the way it is

Backend

  • Add model tests for new user fields/relationships
  • Update user model for required fields/relationships
  • Add test for update user endpoint
  • Add user update endpoint
  • Create an API endpoint named /api-schema.json that will generate an OpenAPI compliant schema of all the endpoints currently available in the application.
  • Code documentation and annotation of why system is the way it is

DoD:

  • minimum 90% code coverage test
  • 0 linting errors and warnings
  • 0 accessibility errors
  • deployed to a dev environment
  • all significant changes have been documented
  • free of high and medium security vulnerabilities
  • @lauraGgit has reviewed and signed off

Open question: How do we validate if the new user is a representative of the STT that is selected during creating a new user profile? What are the security implications of sharing the information (PII?) gathered during a new user requesting access with STT and/or OFA admins? Issue has been created to address this #210

Note from sprint demo 9/1: OFA data team stated that they would generally want to know users that are being added/deleted but do not want to manage addition and deletion (unassignment of roles?) of users, as the latter will become burdensome.

Open Questions:

  • How will someone be invited?
  • How OFA will manage the STT list and what functionality needs to be built to enable editing, if any.

Resources:

Screen Shot 2020-09-02 at 3.07.38 PM.png

@lfrohlich
Copy link
Collaborator Author

@adamcaron @carltonsmith we're considering this for this next sprint. Could you please build out the tasks before sprint planning? CC: @RafterGit

@adamcaron adamcaron changed the title As a new user, I can create a profile on the TDP Landing Page As a new user, I can create a profile Sep 2, 2020
@adamcaron adamcaron changed the title As a new user, I can create a profile As a new user, I can enter my first and last name Sep 2, 2020
@shubhi-raft shubhi-raft added this to the Sprint 3 milestone Sep 7, 2020
@RafterGit RafterGit linked a pull request Sep 9, 2020 that will close this issue
12 tasks
@RafterGit RafterGit reopened this Sep 9, 2020
@hilvitzs hilvitzs linked a pull request Sep 10, 2020 that will close this issue
12 tasks
carltonsmith pushed a commit that referenced this issue Feb 19, 2021
Organize security control folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants