Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I can fill out and submit a form to create my profile. #231

Closed
15 of 18 tasks
adamcaron opened this issue Sep 2, 2020 · 6 comments
Closed
15 of 18 tasks
Assignees
Labels
Milestone

Comments

@adamcaron
Copy link

adamcaron commented Sep 2, 2020

Description:
When a user signs in for the first time, they are prompted to create a profile. This issue covers enabling submittal of the form containing first and last name (from #191) and an STT/OFA combo box (from #229) via an API and saving the user's profile to a database.

Acceptance Criteria:

Tasks:
UX (@reitermb):

  • Discuss with @mfkathleen and @lfrohlich to update description text "We need to collect some information" to something else that does not trigger PRA
  • Lauren + Raft UX team to discuss with Denise whether it ok to say associate tribe (as opposed to tribal organization).

Frontend

  • Evaluate moving 'Federal Government' top of the list. Move it to the top of the list if it is quick fix. If it cannot be moved, create a new issue to implement.
  • Implement PATCH to new PATCH endpoint once form controls are validated
  • Implement redirect on successful submission
  • Run Testing Checklist and confirm all tests pass
  • New ticket is created for authentication integration testing with Cypress and Pa11y OTP

Points: 3

Backend

  • Create PATCH endpoint for STTs to update the user's profile
  • Create tests to test the new endpoint
  • Create tests to cover lines 22->37, and 37->41 of the authorization check endpoint to complete test coverage
  • Run Testing Checklist and confirm all tests pass
  • Set /v1/authorization-check endpoint to return users the same as the /v1/set_profile endpoint
  • Add email to the /v1/set_profile endpoint
  • update tests accordingly

Points: 3

Notes:

@adamcaron adamcaron changed the title As a user, when creating a profile, I can submit the form. As a user, when creating a profile, I can submit the form to create my profile. Sep 2, 2020
@shubhi-raft shubhi-raft added the dev label Sep 6, 2020
@lauraGgit
Copy link

per discussion in dev pairing we'll be sure to add an integration test that includes authentication and submission in cypress.

@shubhi-raft shubhi-raft changed the title As a user, when creating a profile, I can submit the form to create my profile. As a user, I can fill out and submit a form to create my profile. Sep 16, 2020
@RafterGit
Copy link

per discussion in dev pairing we'll be sure to add an integration test that includes authentication and submission in cypress.

This will also need to include OTP support for pa11y as mentioned in the SPRINT4 PR Review.

This was referenced Sep 29, 2020
@shubhi-raft shubhi-raft added this to the Sprint 5 milestone Sep 30, 2020
@RafterGit RafterGit linked a pull request Oct 7, 2020 that will close this issue
12 tasks
@alexsoble alexsoble mentioned this issue Oct 9, 2020
15 tasks
@shubhi-raft
Copy link
Collaborator

Per discussions in Teams, noting here @hilvitzs

  • Update 'We need to collect some information before an OFA Admin can grant you access' to 'Please enter your information to request access from an OFA administrator'
  • No update is needed for tribal organization. Lauren confirmed it is ok to say associate tribe in the combobox.

@carltonsmith carltonsmith linked a pull request Nov 10, 2020 that will close this issue
12 tasks
@lfrohlich
Copy link
Collaborator

This has been merged

@lfrohlich
Copy link
Collaborator

This has been merged and accepted

1 similar comment
@lfrohlich
Copy link
Collaborator

This has been merged and accepted

riatzukiza pushed a commit that referenced this issue Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants