Swap Warning / Price Impact component #5722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
walmat
commented
May 14, 2024
walmat
commented
benisgold
reviewed
May 16, 2024
| const updateWarning = useCallback( | ||
| (values: SwapWarning) => { | ||
| 'worklet'; | ||
| swapWarning.modify(prev => ({ ...prev, ...values })); |
There was a problem hiding this comment.
does prev need to be used here at all?
There was a problem hiding this comment.
yeah this pattern is kinda weird but recommended by reanimated :l
benisgold
approved these changes
May 16, 2024
BrodyHughes
added a commit
that referenced
this pull request
May 21, 2024
…x-qr-code-sheet * 'develop' of github.com:rainbow-me/rainbow: (56 commits) review panel fixes (#5747) Account for NaN values on sliderPosition (#5741) add myself to CO for PR approvals (#5743) bump version to v1.9.24 (#5742) Asset Prices (#5724) rm references to old redux swaps const (#5740) Swap Warning / Price Impact component (#5722) add animated coin icons and text fallbacks (#5733) adds ability to select a different output chain id (#5727) fix (#5738) fix positions calling without address (#5729) disable button (#5725) Browser: homepage empty state, search logic fixes (#5737) Add privacy manifest (#5736) swaps and bridge checks on control panel (#5735) Browser: fix control panel crash (#5734) Browser: control panel fixes (#5730) f skylar (#5732) fix account switching (#5726) Browser: release fixes (#5721) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.