Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add animated coin icons and text fallbacks #5733

Merged
merged 9 commits into from
May 16, 2024
Merged

add animated coin icons and text fallbacks #5733

merged 9 commits into from
May 16, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented May 15, 2024 •
edited
Loading

Fixes APP-1455

What changed (plus any additional context for devs)

  • converted swap coin icon to be use AnimatedFasterImage impl.
  • coverted fallback to be an Animated.View

Screen recordings / screenshots

What is left

  • animated chain badge needs to use local png data or serve those from an API

@linear Linear
Copy link

linear bot commented May 15, 2024

APP-1455 Convert SwapCoinIcon to AnimatedFasterImage

christianbaroni
christianbaroni reviewed May 15, 2024
View reviewed changes
Copy link
Member

@christianbaroni christianbaroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is your plan to use these animated coin/chain icon components exclusively for the selected input and output assets? (I think that makes sense, just confirming)

src/__swaps__/screens/Swap/components/AnimatedChainImage.tsx Outdated Show resolved Hide resolved
@walmat
Copy link
Contributor Author

walmat commented May 15, 2024

question: is your plan to use these animated coin/chain icon components exclusively for the selected input and output assets? (I think that makes sense, just confirming)

yep. I guess I should bring back the other version for the coinrow icons. Forgot about that, good call.

@walmat walmat marked this pull request as ready for review May 16, 2024 13:56
@walmat walmat merged commit b528b18 into develop May 16, 2024
6 checks passed
@walmat walmat deleted the @matthew/swap-coin-icons branch May 16, 2024 18:14
BrodyHughes added a commit that referenced this pull request May 21, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/fi…
948f430 
…x-qr-code-sheet

* 'develop' of github.com:rainbow-me/rainbow: (56 commits)
  review panel fixes (#5747)
  Account for NaN values on sliderPosition (#5741)
  add myself to CO for PR approvals (#5743)
  bump version to v1.9.24 (#5742)
  Asset Prices (#5724)
  rm references to old redux swaps const (#5740)
  Swap Warning / Price Impact component (#5722)
  add animated coin icons and text fallbacks (#5733)
  adds ability to select a different output chain id (#5727)
  fix (#5738)
  fix positions calling without address (#5729)
  disable button (#5725)
  Browser: homepage empty state, search logic fixes (#5737)
  Add privacy manifest (#5736)
  swaps and bridge checks on control panel (#5735)
  Browser: fix control panel crash (#5734)
  Browser: control panel fixes (#5730)
  f skylar (#5732)
  fix account switching (#5726)
  Browser: release fixes (#5721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianbaroni christianbaroni christianbaroni left review comments

@benisgold benisgold benisgold approved these changes

Assignees
No one assigned
Labels
swaps v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@walmat @christianbaroni @benisgold @jinchung