Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing source aka fromChainId on bridge calls #5738

Merged
merged 1 commit into from
May 16, 2024
Merged

fix missing source aka fromChainId on bridge calls #5738

merged 1 commit into from
May 16, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented May 16, 2024

No description provided.

brunobar79
brunobar79 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ibrahimtaveras00
ibrahimtaveras00 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@brunobar79 brunobar79 merged commit fc67068 into develop May 16, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @matthew/fix-bridge-missing-fromChainId branch May 16, 2024 16:19
ibrahimtaveras00 pushed a commit that referenced this pull request May 16, 2024
@walmat @ibrahimtaveras00
fix (#5738)
0262a3c
BrodyHughes added a commit that referenced this pull request May 21, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/fi…
948f430 
…x-qr-code-sheet

* 'develop' of github.com:rainbow-me/rainbow: (56 commits)
  review panel fixes (#5747)
  Account for NaN values on sliderPosition (#5741)
  add myself to CO for PR approvals (#5743)
  bump version to v1.9.24 (#5742)
  Asset Prices (#5724)
  rm references to old redux swaps const (#5740)
  Swap Warning / Price Impact component (#5722)
  add animated coin icons and text fallbacks (#5733)
  adds ability to select a different output chain id (#5727)
  fix (#5738)
  fix positions calling without address (#5729)
  disable button (#5725)
  Browser: homepage empty state, search logic fixes (#5737)
  Add privacy manifest (#5736)
  swaps and bridge checks on control panel (#5735)
  Browser: fix control panel crash (#5734)
  Browser: control panel fixes (#5730)
  f skylar (#5732)
  fix account switching (#5726)
  Browser: release fixes (#5721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
swaps v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@walmat @brunobar79 @ibrahimtaveras00 @jinchung